apigee: Added in-place update for consumer_accept_list field in google_apigee_instance

[entertvl]

Fixes hashicorp/terraform-provider-google#14237.

Release Note Template for Downstream PRs (will be copied)

apigee: Added in-place update for `consumer_accept_list` field in `google_apigee_instance`.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 83 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 83 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 41
Passed tests: 14
Skipped tests: 27
Affected tests: 0

Click here to see the affected service packages

• apigee

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[hao-nan-li]

Could you add an update test just to make sure it's working as intended?

[entertvl]

@hao-nan-li
I've added the update test.
Would you mind reviewing this again?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 86 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 394 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 42
Passed tests: 14
Skipped tests: 28
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeInstance_updateConsumerAcceptList
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 278 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 278 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 42
Passed tests: 14
Skipped tests: 28
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeInstance_updateConsumerAcceptList
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 42
Passed tests: 14
Skipped tests: 27
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeInstance_updateConsumerAcceptList

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccApigeeInstance_updateConsumerAcceptList[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[entertvl]

@hao-nan-li
Thank you for letting me know.

I'm trying to build and run the tests again, but errors are occurring in areas outside my focus.
Wait for a while and try again later.

$ cd ~/git/github.com/entertvl/magic-modules
$ git checkout main && git clean -f . && git checkout -- . && git pull
$ cd $GOPATH/src/github.com/hashicorp/terraform-provider-google; git checkout main && git clean -f . && git checkout -- . && git pull
$ cd $GOPATH/src/github.com/hashicorp/terraform-provider-google-beta; git checkout main && git clean -f . && git checkout -- . && git pull
Proceeding with the operation...
Already on 'main'
Your branch is up to date with 'origin/main'.
Already up to date.
Already on 'main'
Your branch is up to date with 'origin/main'.
Already up to date.
Already on 'main'
Your branch is up to date with 'origin/main'.
Already up to date.
Returned to the original directory: ~/git/github.com/entertvl/magic-modules

$ make provider VERSION=ga OUTPUT_PATH="$GOPATH/src/github.com/hashicorp/terraform-provider-google"

$ make provider VERSION=beta OUTPUT_PATH="$GOPATH/src/github.com/hashicorp/terraform-provider-google-beta"

$ cd $GOPATH/src/github.com/hashicorp/terraform-provider-google; make lint
sh -c "'/path/to/go/1.21.3/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
# github.com/hashicorp/terraform-provider-google/google/fwprovider
google/fwprovider/data_source_provider_config_plugin_framework.go:208:38: d.providerConfig.Credentials undefined (type *fwtransport.FrameworkProviderConfig has no field or method Credentials)
make: *** [vet] Error 1

[hao-nan-li]

@hao-nan-li Thank you for letting me know.

I'm trying to build and run the tests again, but errors are occurring in areas outside my focus. Wait for a while and try again later.

$ cd ~/git/github.com/entertvl/magic-modules
$ git checkout main && git clean -f . && git checkout -- . && git pull
$ cd $GOPATH/src/github.com/hashicorp/terraform-provider-google; git checkout main && git clean -f . && git checkout -- . && git pull
$ cd $GOPATH/src/github.com/hashicorp/terraform-provider-google-beta; git checkout main && git clean -f . && git checkout -- . && git pull
Proceeding with the operation...
Already on 'main'
Your branch is up to date with 'origin/main'.
Already up to date.
Already on 'main'
Your branch is up to date with 'origin/main'.
Already up to date.
Already on 'main'
Your branch is up to date with 'origin/main'.
Already up to date.
Returned to the original directory: ~/git/github.com/entertvl/magic-modules

$ make provider VERSION=ga OUTPUT_PATH="$GOPATH/src/github.com/hashicorp/terraform-provider-google"

$ make provider VERSION=beta OUTPUT_PATH="$GOPATH/src/github.com/hashicorp/terraform-provider-google-beta"

$ cd $GOPATH/src/github.com/hashicorp/terraform-provider-google; make lint
sh -c "'/path/to/go/1.21.3/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
# github.com/hashicorp/terraform-provider-google/google/fwprovider
google/fwprovider/data_source_provider_config_plugin_framework.go:208:38: d.providerConfig.Credentials undefined (type *fwtransport.FrameworkProviderConfig has no field or method Credentials)
make: *** [vet] Error 1

Have you set GOOGLE_CREDENTIALS? https://googlecloudplatform.github.io/magic-modules/get-started/generate-providers/#test-changes

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 278 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 278 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 42
Passed tests: 14
Skipped tests: 28
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeInstance_updateConsumerAcceptList
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[entertvl]

Have you set GOOGLE_CREDENTIALS?

Yes, I was able to build successfully with ADC before, and they are still set.

$ printenv | grep GOOGLE
GOOGLE_BILLING_ACCOUNT=
GOOGLE_ORG=
GOOGLE_FOLDER=
GOOGLE_PROJECT=
GOOGLE_REGION=
GOOGLE_ZONE=
GOOGLE_USE_DEFAULT_CREDENTIALS=true

[hao-nan-li]

Have you set GOOGLE_CREDENTIALS?

Yes, I was able to build successfully with ADC before, and they are still set.

$ printenv | grep GOOGLE
GOOGLE_BILLING_ACCOUNT=
GOOGLE_ORG=
GOOGLE_FOLDER=
GOOGLE_PROJECT=
GOOGLE_REGION=
GOOGLE_ZONE=
GOOGLE_USE_DEFAULT_CREDENTIALS=true

Could you rebase and clean all existing change from TPG? Also make sure to pull the latest change from TPG

[entertvl]

Could you rebase and clean all existing change from TPG? Also make sure to pull the latest change from TPG

Thank you, I was able to re-run the testacc by rebasing.

I do see that the added functionality works fine, but need to check the entire log including the deletion part.

I found a solution from new features of project deletion_policy, it was explicitly specifying a value is required for project deletion.

And re-run tests result here from locally:

TF_LOG=DEBUG make testacc TEST=./google/services/apigee TESTARGS='-run=TestAccApigeeInstance_' > test.log

https://gist.github.com/entertvl/b20734230df59d28f29674fe0831a028

[hao-nan-li]

Could you rebase and clean all existing change from TPG? Also make sure to pull the latest change from TPG

Thank you, I was able to re-run the testacc by rebasing.

I do see that the added functionality works fine, but need to check the entire log including the deletion part.

I found a solution from new features of project deletion_policy, it was explicitly specifying a value is required for project deletion.

And re-run tests result here from locally:

TF_LOG=DEBUG make testacc TEST=./google/services/apigee TESTARGS='-run=TestAccApigeeInstance_' > test.log

https://gist.github.com/entertvl/b20734230df59d28f29674fe0831a028

Looks like there's a URL malformed error in the log, any chance of fixing it locally?

[entertvl]

Will check if it's possible to fix the sections where the two test cases are failing in the log.

--- FAIL: TestAccApigeeInstance_apigeeInstanceIpRangeTestExample (148.20s)
--- FAIL: TestAccApigeeInstance_apigeeInstanceServiceAttachmentBasicTestExample (2450.98s)

[entertvl]

--- FAIL: TestAccApigeeInstance_apigeeInstanceIpRangeTestExample (148.20s)

• Passed when run single test (test log)
• Likely failed due to parallel execution with other tests
• No code changes

--- FAIL: TestAccApigeeInstance_apigeeInstanceServiceAttachmentBasicTestExample (2450.98s)

• It seems that pass a literal IP address caused an error
• Replaced it with the resource ID like partial URL or by name as per the doc
• Passed when single test (test log)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 282 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 282 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 42
Passed tests: 14
Skipped tests: 28
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeInstance_updateConsumerAcceptList
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[hao-nan-li]

Could you confirm TestAccApigeeInstance_updateConsumerAcceptList passed locally? If so we're good to go.

[entertvl]

Could you confirm TestAccApigeeInstance_updateConsumerAcceptList passed locally?

Results of local testing here:

--- PASS: TestAccApigeeInstance_updateConsumerAcceptList (2600.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google/services/apigee	2601.368s

https://gist.github.com/entertvl/2f29a4fde72df615436a960dac1ba3e6