Skip to content

Revert "Prevent Dataflow options in parameters" #11485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

Revert "Prevent Dataflow options in parameters" #11485

merged 1 commit into from
Aug 20, 2024

Conversation

shuyama1
Copy link
Member 

dataflow: made provider return more descriptive errors when the `parameters` field of `google_dataflow_flex_template_job` contains Dataflow options (revert)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 52 insertions(+), 56 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@shuyama1 shuyama1 requested a review from trodge August 19, 2024 17:36
@shuyama1
Copy link
Member Author

Thanks @trodge @melinath! Sorry, forgot that this PR is still open

@shuyama1 shuyama1 merged commit 8a8e61c into main Aug 20, 2024
11 checks passed
@shuyama1 shuyama1 deleted the revert-11153-fix-dataflow-flex-template-job-streaming-engine-param branch August 20, 2024 21:40
This was referenced Aug 20, 2024
Merged
Merged
Merged
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
@shuyama1 @BBBmau
Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#…
7df747f 
…11485)
c2thorn added a commit to c2thorn/magic-modules that referenced this pull request Aug 21, 2024
@c2thorn
Merge commit 'bc5def9f8136003836911e78567dc8849a39be6d' into sync-mai…
bc3986d 
…n-FEATURE-BRANCH-6.0.0

* commit 'bc5def9f8136003836911e78567dc8849a39be6d':
  Fix test `TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule` (GoogleCloudPlatform#11469)
  Promoted labelFingerprint field to GA (GoogleCloudPlatform#11504)
  Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#11485)
  Support Undelete for Vmwareengine Private Cloud (GoogleCloudPlatform#11480)
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2024
@shuyama1 @rainshen49
Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#…
41aa53c 
…11485)
dominykasn pushed a commit to dominykasn/magic-modules that referenced this pull request Aug 27, 2024
@shuyama1 @dominykasn
Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#…
e805ca3 
…11485)
dominykasn added a commit to dominykasn/magic-modules that referenced this pull request Aug 27, 2024
@dominykasn
Revert "Revert "Prevent Dataflow options in parameters" (GoogleCloudP…
8690723 
…latform#11485)"

This reverts commit e805ca3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

@trodge trodge trodge approved these changes

Assignees
No one assigned
Labels
service/dataflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuyama1 @modular-magician @melinath @trodge