-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add acceptance tests for how provider handles scopes
argument
#11860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance tests for how provider handles scopes
argument
#11860
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Tests analyticsTotal tests: 4101 Click here to see the affected service packages
View the build log |
I'm not sure what's going on in the failure above, very hard to search in the logs |
/gcbrun |
Tests analyticsTotal tests: 4107 Click here to see the affected service packages
View the build log |
//no ENVs to test | ||
|
||
// Schema-level validation | ||
"when scopes is set to an empty array in the config the value is ignored and default scopes are used": testAccSdkProvider_scopes_emptyArray, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice capturing this case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😁 We could add some validation in future to make the scenario more explicit, i.e. block empty arrays so users aren't lulled into a false sense of using no scopes, but that'd be a breaking change. And I don't even know if setting zero scopes is something users would attempt to do, but I can imagine there's someone out there doing it!
This PR adds acceptance tests for usage of scopes that demonstrate:
Release Note Template for Downstream PRs (will be copied)