Skip to content

Add acceptance tests for how provider handles scopes argument #19690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

This PR adds acceptance tests for usage of scopes that demonstrate:

  • how the provider behaves when provider configuration arguments come from different sources ( config vs ENVs)
    • There are no ENVs for scopes
    • There is a default set of scopes used if the argument isn't supplied
  • schema-level validation that's in place
    • There isn't any validation about empty lists, instead the empty list is ignored
  • use cases: how does this argument impact the providers behaviour in plan/apply
    • I've implemented a test case where setting the scopes to incorrect values causes provisioning to fail.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11860

…icorp#11860)

[upstream:2c7fe8a6b59d7dcb0a031b1139410dc34e0d1bc8]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit d4730fd into hashicorp:main Sep 30, 2024
2 checks passed
Copy link

github-actions bot commented Nov 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
@modular-magician modular-magician deleted the downstream-pr-2c7fe8a6b59d7dcb0a031b1139410dc34e0d1bc8 branch November 16, 2024 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant