Skip to content

Adding missing fields to vertexai.Endpoint resource #12110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Nov 4, 2024

Conversation

mmurakowski-verily
Copy link
Contributor

@mmurakowski-verily mmurakowski-verily commented Oct 23, 2024

Fixes hashicorp/terraform-provider-google#19995

We were missing a few fields so I added them. enable_private_service_connect is deprecated and seems to always return "false" now, so I'm skipping it.

traffic_split can't actually be set on resource creation, you need to "deploy" a model associated with the endpoint, and you need to have deployed a model in order to get the keys in the map. I think traffic_split only applies to the new config I'm enabling here, so it's hard to test anyway.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

vertexai: added `traffic_split`, `private_service_connect_config`, `predict_request_response_logging_config`, `dedicated_endpoint_enabled`, and `dedicated_endpoint_dns` fields to `google_vertex_ai_endpoint` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 486 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 486 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  dedicated_endpoint_enabled     = # value needed
  enable_private_service_connect = # value needed
  predict_request_response_logging_config {
    bigquery_destination {
      output_uri = # value needed
    }
    enabled       = # value needed
    sampling_rate = # value needed
  }
  private_service_connect_config {
    enable_private_service_connect        = # value needed
    enable_secure_private_service_connect = # value needed
    project_allowlist                     = # value needed
  }
  traffic_split = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 486 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 486 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  dedicated_endpoint_enabled     = # value needed
  enable_private_service_connect = # value needed
  predict_request_response_logging_config {
    bigquery_destination {
      output_uri = # value needed
    }
    enabled       = # value needed
    sampling_rate = # value needed
  }
  private_service_connect_config {
    enable_private_service_connect        = # value needed
    enable_secure_private_service_connect = # value needed
    project_allowlist                     = # value needed
  }
  traffic_split = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 50
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 50
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 636 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 942 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 121 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  dedicated_endpoint_enabled = # value needed
  predict_request_response_logging_config {
    bigquery_destination {
      output_uri = # value needed
    }
    enabled       = # value needed
    sampling_rate = # value needed
  }
  traffic_split = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 636 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 942 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 121 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  dedicated_endpoint_enabled = # value needed
  predict_request_response_logging_config {
    bigquery_destination {
      output_uri = # value needed
    }
    enabled       = # value needed
    sampling_rate = # value needed
  }
  traffic_split = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • vertexai
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • vertexai
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 642 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 963 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 124 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  predict_request_response_logging_config {
    bigquery_destination {
      output_uri = # value needed
    }
    enabled       = # value needed
    sampling_rate = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • vertexai
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 660 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 1026 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • vertexai
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@mmurakowski-verily mmurakowski-verily marked this pull request as ready for review October 24, 2024 08:28
@github-actions github-actions bot requested a review from ScottSuarez October 24, 2024 08:29
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 660 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 5 files changed, 1026 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • vertexai
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 660 insertions(+), 47 deletions(-))
google-beta provider: Diff ( 5 files changed, 1026 insertions(+), 47 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • vertexai
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 660 insertions(+), 47 deletions(-))
google-beta provider: Diff ( 6 files changed, 1028 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 701 insertions(+), 52 deletions(-))
google-beta provider: Diff ( 6 files changed, 1004 insertions(+), 54 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 150 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 234 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  traffic_split = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 701 insertions(+), 52 deletions(-))
google-beta provider: Diff ( 6 files changed, 1004 insertions(+), 54 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 150 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 234 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  traffic_split = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 50
Skipped tests: 3
Affected tests: 5

Click here to see the affected service packages
  • vertexai

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointNetwork
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVertexAIEndpointIamBindingGenerated [Debug log]
TestAccVertexAIEndpointIamMemberGenerated [Debug log]
TestAccVertexAIEndpointIamPolicyGenerated [Debug log]
TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 50
Skipped tests: 3
Affected tests: 5

Click here to see the affected service packages
  • vertexai

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIEndpointIamBindingGenerated
  • TestAccVertexAIEndpointIamMemberGenerated
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIEndpoint_vertexAiEndpointNetwork
  • TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVertexAIEndpointIamBindingGenerated [Debug log]
TestAccVertexAIEndpointIamMemberGenerated [Debug log]
TestAccVertexAIEndpointIamPolicyGenerated [Debug log]
TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 695 insertions(+), 47 deletions(-))
google-beta provider: Diff ( 6 files changed, 998 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 150 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 234 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  traffic_split = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 54
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIEndpoint_vertexAiEndpointNetwork

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to discuss with contributor on traffic_split functionality

@github-actions github-actions bot requested a review from ScottSuarez November 4, 2024 17:52
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 704 insertions(+), 47 deletions(-))
google-beta provider: Diff ( 6 files changed, 1007 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 150 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 234 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  traffic_split = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 704 insertions(+), 47 deletions(-))
google-beta provider: Diff ( 6 files changed, 1007 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 150 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 234 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  traffic_split = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Endpoint.trafficSplit and Endpoint.predictRequestResponseLoggingConfig
3 participants