-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Adding missing fields to vertexai.Endpoint resource #12110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing fields to vertexai.Endpoint resource #12110
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
dedicated_endpoint_enabled = # value needed
enable_private_service_connect = # value needed
predict_request_response_logging_config {
bigquery_destination {
output_uri = # value needed
}
enabled = # value needed
sampling_rate = # value needed
}
private_service_connect_config {
enable_private_service_connect = # value needed
enable_secure_private_service_connect = # value needed
project_allowlist = # value needed
}
traffic_split = # value needed
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
dedicated_endpoint_enabled = # value needed
enable_private_service_connect = # value needed
predict_request_response_logging_config {
bigquery_destination {
output_uri = # value needed
}
enabled = # value needed
sampling_rate = # value needed
}
private_service_connect_config {
enable_private_service_connect = # value needed
enable_secure_private_service_connect = # value needed
project_allowlist = # value needed
}
traffic_split = # value needed
}
|
Tests analyticsTotal tests: 53 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 53 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
dedicated_endpoint_enabled = # value needed
predict_request_response_logging_config {
bigquery_destination {
output_uri = # value needed
}
enabled = # value needed
sampling_rate = # value needed
}
traffic_split = # value needed
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
dedicated_endpoint_enabled = # value needed
predict_request_response_logging_config {
bigquery_destination {
output_uri = # value needed
}
enabled = # value needed
sampling_rate = # value needed
}
traffic_split = # value needed
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
predict_request_response_logging_config {
bigquery_destination {
output_uri = # value needed
}
enabled = # value needed
sampling_rate = # value needed
}
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
traffic_split = # value needed
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
traffic_split = # value needed
}
|
Tests analyticsTotal tests: 58 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 58 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
traffic_split = # value needed
}
|
Tests analyticsTotal tests: 58 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to discuss with contributor on traffic_split functionality
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
traffic_split = # value needed
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_endpoint" "primary" {
traffic_split = # value needed
}
|
Tests analyticsTotal tests: 58 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 58 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Fixes hashicorp/terraform-provider-google#19995
We were missing a few fields so I added them.
enable_private_service_connect
is deprecated and seems to always return "false" now, so I'm skipping it.traffic_split
can't actually be set on resource creation, you need to "deploy" a model associated with the endpoint, and you need to have deployed a model in order to get the keys in the map. I thinktraffic_split
only applies to the new config I'm enabling here, so it's hard to test anyway.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.