Skip to content

Adding missing fields to vertexai.Endpoint resource #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#19995

We were missing a few fields so I added them. enable_private_service_connect is deprecated and seems to always return "false" now, so I'm skipping it.

traffic_split can't actually be set on resource creation, you need to "deploy" a model associated with the endpoint, and you need to have deployed a model in order to get the keys in the map. I think traffic_split only applies to the new config I'm enabling here, so it's hard to test anyway.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

vertexai: added `traffic_split`, `private_service_connect_config`, `predict_request_response_logging_config`, `dedicated_endpoint_enabled`, and `dedicated_endpoint_dns` fields to `google_vertex_ai_endpoint` resource

Derived from GoogleCloudPlatform/magic-modules#12110

[upstream:ee5b3de20ce91c5cf5cffd417512a498ff16e09f]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner November 4, 2024 19:09
@modular-magician modular-magician requested review from shuyama1 and removed request for a team November 4, 2024 19:09
@modular-magician modular-magician merged commit 5829134 into GoogleCloudPlatform:main Nov 4, 2024
1 check passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-ee5b3de20ce91c5cf5cffd417512a498ff16e09f branch November 18, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Endpoint.trafficSplit and Endpoint.predictRequestResponseLoggingConfig
1 participant