-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ephemeral
: add ephemeral_google_service_account_jwt
#12142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ephemeral
: add ephemeral_google_service_account_jwt
#12142
Conversation
ephemeral
: add ephemeral_google_service_account_jwt
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
020c7f0
to
5ff769e
Compare
tests are passing: === RUN TestEphemeralServiceAccountJwt_basic
=== PAUSE TestEphemeralServiceAccountJwt_basic
=== RUN TestEphemeralServiceAccountJwt_withDelegates
=== PAUSE TestEphemeralServiceAccountJwt_withDelegates
=== RUN TestEphemeralServiceAccountJwt_withExpiresIn
=== PAUSE TestEphemeralServiceAccountJwt_withExpiresIn
=== CONT TestEphemeralServiceAccountJwt_basic
=== CONT TestEphemeralServiceAccountJwt_withExpiresIn
=== CONT TestEphemeralServiceAccountJwt_withDelegates
2024/11/06 22:15:18 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 22:15:18 [INFO] -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 22:15:18 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 22:15:18 [INFO] -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 22:15:18 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 22:15:18 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 22:15:18 [INFO] -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 22:15:18 [INFO] -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 22:15:18 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 22:15:18 [INFO] -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 22:15:18 [DEBUG] Waiting for state to become: [success]
2024/11/06 22:15:18 [DEBUG] Waiting for state to become: [success]
2024/11/06 22:15:18 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 22:15:18 [INFO] -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 22:15:18 [DEBUG] Waiting for state to become: [success]
2024/11/06 22:15:19 [INFO] Terraform is using this identity: mauricio-alvarezleon@hc-terraform-testing.iam.gserviceaccount.com
2024/11/06 22:15:19 [DEBUG] Verifying projects/hc-terraform-testing/serviceAccounts/tf-bootstrap-sa-basic@hc-terraform-testing.iam.gserviceaccount.com as bootstrapped service account.
2024/11/06 22:15:19 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 22:15:19 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 22:15:19 [DEBUG] Retry Transport: request attempt 0
2024/11/06 22:15:19 [INFO] Terraform is using this identity: mauricio-alvarezleon@hc-terraform-testing.iam.gserviceaccount.com
2024/11/06 22:15:19 [DEBUG] Verifying projects/hc-terraform-testing/serviceAccounts/tf-bootstrap-sa-expiry@hc-terraform-testing.iam.gserviceaccount.com as bootstrapped service account.
2024/11/06 22:15:19 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 22:15:19 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 22:15:19 [DEBUG] Retry Transport: request attempt 0
2024/11/06 22:15:19 [INFO] Terraform is using this identity: mauricio-alvarezleon@hc-terraform-testing.iam.gserviceaccount.com
2024/11/06 22:15:19 [DEBUG] Verifying projects/hc-terraform-testing/serviceAccounts/tf-bootstrap-sa-delegates@hc-terraform-testing.iam.gserviceaccount.com as bootstrapped service account.
2024/11/06 22:15:19 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 22:15:19 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 22:15:19 [DEBUG] Retry Transport: request attempt 0
2024/11/06 22:15:19 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 22:15:19 [DEBUG] Retry Transport: Returning after 1 attempts
2024/11/06 22:15:19 [DEBUG] Setting service account permissions.
2024/11/06 22:15:19 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 22:15:19 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 22:15:19 [DEBUG] Retry Transport: request attempt 0
2024/11/06 22:15:19 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 22:15:19 [DEBUG] Retry Transport: Returning after 1 attempts
2024/11/06 22:15:19 [DEBUG] Setting service account permissions.
2024/11/06 22:15:19 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 22:15:19 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 22:15:19 [DEBUG] Retry Transport: request attempt 0
2024/11/06 22:15:19 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 22:15:19 [DEBUG] Retry Transport: Returning after 1 attempts
2024/11/06 22:15:19 [DEBUG] Setting service account permissions.
2024/11/06 22:15:19 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 22:15:19 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 22:15:19 [DEBUG] Retry Transport: request attempt 0
2024/11/06 22:15:19 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 22:15:19 [DEBUG] Retry Transport: Returning after 1 attempts
--- PASS: TestEphemeralServiceAccountJwt_basic (20.89s)
--- PASS: TestEphemeralServiceAccountJwt_withExpiresIn (21.11s)
--- PASS: TestEphemeralServiceAccountJwt_withDelegates (21.88s)
PASS
ok github.com/hashicorp/terraform-provider-google/google/services/resourcemanager 26.414s |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@SarahFrench fwiw this can be reviewed separately since it doesn't contain any Validators. However i think it would be best if this is reviewed once we merged all the other PRs (basically leave this for last, not high priority) |
Ok, in that case let's mark this PR as draft until it's ready to be reviewed |
5ff769e
to
8692182
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4267 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
marking this as ready for review but it's understood that it will be reviewed once the resources quoted above are merged. Only marking since I've done some final refinement that marks this PR in good standing |
1 similar comment
Tests analyticsTotal tests: 4273 Click here to see the affected service packages
Action takenFound 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 4273 Click here to see the affected service packages
Action takenFound 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review pass!
mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/ephemeral-resources/service_account_jwt.html.markdown
Outdated
Show resolved
Hide resolved
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 4273 Click here to see the affected service packages
Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
.../third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt_test.go
Outdated
Show resolved
Hide resolved
89c1037
to
2bb1986
Compare
Tests analyticsTotal tests: 4276 Click here to see the affected service packages
Action takenFound 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but with two pieces of feedback I'd like you to act on before merging
mmv1/third_party/terraform/fwvalidators/framework_validators.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt.go
Outdated
Show resolved
Hide resolved
…google_service_account_jwt.go Co-authored-by: Sarah French <[email protected]>
mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_jwt.go
Outdated
Show resolved
Hide resolved
…google_service_account_jwt.go
1 similar comment
b1c6428
into
GoogleCloudPlatform:FEATURE-BRANCH-ephemeral-resource
Tests analyticsTotal tests: 4276 Click here to see the affected service packages
Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
2 similar comments
Tests analyticsTotal tests: 4276 Click here to see the affected service packages
Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 4276 Click here to see the affected service packages
Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 4276 Click here to see the affected service packages
Action takenFound 245 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
An ephemeral resource that mimics the google_service_account_jwt data source
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.