Skip to content

FEATURE: release ephemeral resources support #12469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Dec 2, 2024

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Dec 2, 2024

Requires Terraform 1.10+

This PR will include support of ephemeral resources, starting with the following resources in this PR:

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_service_account_access_token`
`google_service_account_jwt`
`google_service_account_key`
`google_service_account_id_token`

SarahFrench and others added 30 commits October 3, 2024 18:46
@BBBmau BBBmau requested a review from SarahFrench December 2, 2024 19:31
@SarahFrench
Copy link
Contributor

The release notes are failing a check, but tbh whatever we put for the release notes isn't what'll be in the final CHANGELOG entry. I suggest we just ignore that check, given the circumstances

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 1809 insertions(+), 150 deletions(-))
google-beta provider: Diff ( 21 files changed, 1809 insertions(+), 150 deletions(-))

@SarahFrench
Copy link
Contributor

Diffs look good, though I'd like to see the automation about tests before reviewing

@BBBmau
Copy link
Collaborator Author

BBBmau commented Dec 2, 2024

This PR fixes the unit bulild test failure which is just due to not including ephemeral-resources as part of the docscheck script: hashicorp/terraform-provider-google#20540

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4337
Passed tests: 3912
Skipped tests: 405
Affected tests: 20

Click here to see the affected service packages

All service packages are affected

Action taken

Found 20 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountIdToken_basic
  • TestAccEphemeralServiceAccountIdToken_withDelegates
  • TestAccEphemeralServiceAccountIdToken_withEmptyDelegates
  • TestAccEphemeralServiceAccountIdToken_withIncludeEmail
  • TestAccEphemeralServiceAccountJwt_basic
  • TestAccEphemeralServiceAccountJwt_withDelegates
  • TestAccEphemeralServiceAccountJwt_withExpiresIn
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccEphemeralServiceAccountToken_basic
  • TestAccEphemeralServiceAccountToken_withCustomLifetime
  • TestAccEphemeralServiceAccountToken_withDelegates
  • TestAccOracleDatabaseAutonomousDatabase_basic
  • TestAccOracleDatabaseAutonomousDatabases_basic
  • TestAccOracleDatabaseCloudExadataInfrastructure_basic
  • TestAccOracleDatabaseCloudExadataInfrastructures_basic
  • TestAccOracleDatabaseCloudVmCluster_basic
  • TestAccOracleDatabaseDbNodes_basic
  • TestAccOracleDatabaseDbServers_basic
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@SarahFrench
Copy link
Contributor

SarahFrench commented Dec 2, 2024

Test results look good- ephemeral ones we knew would fail, and the Oracle ones have been failing on PRs for a while so are expected- all looks ok to me

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_withDelegates [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_withEmptyDelegates [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_withIncludeEmail [Error message] [Debug log]
TestAccEphemeralServiceAccountJwt_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountJwt_withDelegates [Error message] [Debug log]
TestAccEphemeralServiceAccountJwt_withExpiresIn [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withCustomLifetime [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withDelegates [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants