-
Notifications
You must be signed in to change notification settings - Fork 1.8k
FEATURE
: release ephemeral resources support
#12469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…RE-BRANCH-ephemeral-resources
…est.go Co-authored-by: Sarah French <[email protected]>
…est.go Co-authored-by: Sarah French <[email protected]>
…est.go Co-authored-by: Sarah French <[email protected]>
…est.go Co-authored-by: Sarah French <[email protected]>
…RE-BRANCH-ephemeral-resources
…rce' into sync-main-FEATURE-BRANCH-ephemeral-resources
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Sarah French <[email protected]> Co-authored-by: Sarah French <[email protected]>
… add notes, misc fixes (#12448)
The release notes are failing a check, but tbh whatever we put for the release notes isn't what'll be in the final CHANGELOG entry. I suggest we just ignore that check, given the circumstances |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Diffs look good, though I'd like to see the automation about tests before reviewing |
This PR fixes the unit bulild test failure which is just due to not including |
Tests analyticsTotal tests: 4337 Click here to see the affected service packages
Action takenFound 20 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Test results look good- ephemeral ones we knew would fail, and the Oracle ones have been failing on PRs for a while so are expected- all looks ok to me |
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TeamCity
: update defaultTerraformCoreVersion
to 1.10.0
hashicorp/terraform-provider-google-beta#8816
…2469) Co-authored-by: Sarah French <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Sarah French <[email protected]>
…2469) Co-authored-by: Sarah French <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Sarah French <[email protected]>
Requires Terraform 1.10+
This PR will include support of ephemeral resources, starting with the following resources in this PR:
ephemeral
: addephemeral_google_service_account_key
#12143ephemeral
: addephemeral_google_service_account_jwt
#12142ephemeral
: addgoogle_service_account_id_token
#12141ephemeral
: addephemeral_google_service_account_access_token
#12140Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.