Skip to content

add external_credentials support in provider block #12714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 26, 2025

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Jan 9, 2025

Release Note Template for Downstream PRs (will be copied)

This adds external_credentials support allowing you to implement credentials such as WIF

screenshot shows successful apply with the previous error occurring when commenting out the external_credentials.

image

provider that was used for testing this feature is found here: BBBmau/terraform-provider-google@caadf43#diff-3f3fc7ca4bb3b70c74628fe4092a22f6540b4367b2ce9f57766def8093a38a07R1612

Validation

Refer to this comment for the most up-to date validation video

2025-01-09.15-00-17.mov

See Write release notes for guidance.

`external_credentials` block in provider

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 112 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 4 files changed, 112 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4416
Passed tests: 3983
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau BBBmau requested a review from c2thorn January 9, 2025 23:19
@BBBmau BBBmau marked this pull request as ready for review January 9, 2025 23:20
Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the video, considering the extra setup involved with testing. It would be nice to get some sort of unit testing related to the logic - maybe to verify what happens with conflicting credential information or environment variables.

Also, we would want some documentation around the new block and fields right?

}
config.ExternalCredentials = externalCredentials
}

// only check environment variables if neither value was set in config- this
// means config beats env var in all cases.
if config.AccessToken == "" && config.Credentials == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't we want to exclude checking for the other credentials here if we've already found External Credentials?

Otherwise, have you tested what happens if we have both these environment variables and external credentials?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1470e65 - will not check the other auth fields if external_credentials is set

We also prevent the use of environment variables if external_credentials == nil since configuration takes precedence over environment variables.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 161 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 6 files changed, 161 insertions(+), 20 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Copy link

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Copy link

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Copy link

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Copy link

@BBBmau, this PR is being closed due to inactivity.

@github-actions github-actions bot closed this Feb 26, 2025
@BBBmau BBBmau reopened this Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 214 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 7 files changed, 214 insertions(+), 20 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@BBBmau BBBmau marked this pull request as draft March 11, 2025 02:24
@BBBmau BBBmau force-pushed the external-credentials-provider branch from 4a0572f to 1470e65 Compare March 11, 2025 02:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 222 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 7 files changed, 222 insertions(+), 28 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 227 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 7 files changed, 227 insertions(+), 28 deletions(-))

@BBBmau BBBmau force-pushed the external-credentials-provider branch 2 times, most recently from 8ae1a6a to 4129233 Compare March 11, 2025 03:52
@BBBmau
Copy link
Collaborator Author

BBBmau commented Mar 11, 2025

I'll be working on the docs before moving it to Review, though i do think the recent updates are worth a quick glance @c2thorn

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 227 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 7 files changed, 227 insertions(+), 28 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 227 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 7 files changed, 227 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccComputeInstanceFromMachineImage_terminationTime [Debug log]
TestAccComputeInstanceFromTemplate_TerminationTime [Debug log]
TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccComputeInstance_schedulingTerminationTime [Debug log]
TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildFullExample [Debug log]
TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildMinimalExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample [Debug log]
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample [Debug log]
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Debug log]
TestAccApigeeEnvironmentIamMemberGenerated [Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesBetaTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsTestExample [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Debug log]
TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample [Debug log]
TestAccApigeeSyncAuthorization_update [Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTestExample [Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTest_update [Debug log]
TestAccApihubHostProjectRegistration_apihubHostProjectRegistrationBasicExample [Debug log]
TestAccApphubService_apphubServiceBasicExample [Debug log]
TestAccApphubService_apphubServiceFullExample [Debug log]
TestAccApphubService_serviceUpdate [Debug log]
TestAccApphubWorkload_apphubWorkloadBasicExample [Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample [Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate [Debug log]
TestAccBigqueryAnalyticsHubListingSubscription_differentProject [Debug log]
TestAccBinaryAuthorizationPolicy_basic [Debug log]
TestAccBinaryAuthorizationPolicy_full [Debug log]
TestAccBinaryAuthorizationPolicy_separateProject [Debug log]
TestAccBinaryAuthorizationPolicy_update [Debug log]
TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample [Debug log]
TestAccComputeInstanceFromMachineImage_diffProject [Debug log]
TestAccComputeProjectCloudArmorTier_basic [Debug log]
TestAccComputeProjectCloudArmorTier_modify [Debug log]
TestAccComputeProjectDefaultNetworkTier_basic [Debug log]
TestAccComputeProjectDefaultNetworkTier_modify [Debug log]
TestAccComputeProjectMetadata_modify_1 [Debug log]
TestAccComputeProjectMetadata_modify_2 [Debug log]
TestAccComputeResourceUsageExportBucket [Debug log]
TestAccComputeSharedReservation_update [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinitySpecific [Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivateMultiprojectExample [Debug log]
TestAccDNSPolicy_dnsPolicyMultiprojectExample [Debug log]
TestAccDataSourceApphubDiscoveredService_basic [Debug log]
TestAccDataSourceApphubDiscoveredWorkload_basic [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic [Debug log]
TestAccDialogflowAgent_update [Debug log]
TestAccDialogflowEntityType_update [Debug log]
TestAccDialogflowFulfillment_update [Debug log]
TestAccDialogflowIntent_basic [Debug log]
TestAccDialogflowIntent_dialogflowIntentFullExample [Debug log]
TestAccDialogflowIntent_update [Debug log]
TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseFull [Debug log]
TestAccEventarcGoogleApiSource_update [Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigFullExample [Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigMinimalExample [Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigUpdate [Debug log]
TestAccFirebaseAppCheckRecaptchaEnterpriseConfig_firebaseAppCheckRecaptchaEnterpriseConfigBasicExample [Debug log]
TestAccFirebaseAppCheckRecaptchaEnterpriseConfig_firebaseAppCheckRecaptchaEnterpriseConfigUpdate [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigEnforcedExample [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigOffExample [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUnenforcedExample [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUpdate [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendFullExample [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendMinimalExample [Debug log]
TestAccFirebaseDataConnectService_Update [Debug log]
TestAccFirebaseDataConnectService_firebasedataconnectServiceBasicExample [Debug log]
TestAccFirebaseDataConnectService_firebasedataconnectServiceWithForceDeletionExample [Debug log]
TestAccFirebaseDatabaseInstance_firebaseDatabaseInstanceDefaultDatabaseExample [Debug log]
TestAccFirestoreDocument_firestoreDocumentBasicExample [Debug log]
TestAccFirestoreDocument_firestoreDocumentNestedDocumentExample [Debug log]
TestAccFirestoreDocument_update [Debug log]
TestAccFirestoreField_firestoreFieldUpdateAddIndexExample [Debug log]
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update [Debug log]
TestAccIapBrand_iapBrandExample [Debug log]
TestAccIapClient_Datasource_basic [Debug log]
TestAccIapClient_iapClientExample [Debug log]
TestAccIapSettings_update [Debug log]
TestAccIapTunnelIamBindingGenerated [Debug log]
TestAccIapTunnelIamBindingGenerated_withCondition [Debug log]
TestAccIapTunnelIamMemberGenerated [Debug log]
TestAccIapTunnelIamMemberGenerated_withCondition [Debug log]
TestAccIapTunnelIamPolicyGenerated [Debug log]
TestAccIapTunnelIamPolicyGenerated_withCondition [Debug log]
TestAccIapWebIamBindingGenerated [Debug log]
TestAccIapWebIamBindingGenerated_withCondition [Debug log]
TestAccIapWebIamMemberGenerated [Debug log]
TestAccIapWebIamMemberGenerated_withCondition [Debug log]
TestAccIapWebIamPolicyGenerated [Debug log]
TestAccIapWebIamPolicyGenerated_withCondition [Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated [Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition [Debug log]
TestAccIapWebTypeAppEngineIamMemberGenerated [Debug log]
TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition [Debug log]
TestAccIapWebTypeAppEngineIamPolicyGenerated [Debug log]
TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition [Debug log]
TestAccIapWebTypeComputeIamBindingGenerated [Debug log]
TestAccIapWebTypeComputeIamBindingGenerated_withCondition [Debug log]
TestAccIapWebTypeComputeIamMemberGenerated [Debug log]
TestAccIapWebTypeComputeIamMemberGenerated_withCondition [Debug log]
TestAccIapWebTypeComputeIamPolicyGenerated [Debug log]
TestAccIapWebTypeComputeIamPolicyGenerated_withCondition [Debug log]
TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample [Debug log]
TestAccIdentityPlatformConfig_identityPlatformConfigWithFalseValuesExample [Debug log]
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Debug log]
TestAccKmsCryptoKeyIamBinding [Debug log]
TestAccKmsCryptoKeyIamBinding_withCondition [Debug log]
TestAccKmsCryptoKeyIamMember [Debug log]
TestAccKmsCryptoKeyIamMember_withCondition [Debug log]
TestAccKmsCryptoKeyIamPolicy [Debug log]
TestAccKmsCryptoKeyIamPolicy_withCondition [Debug log]
TestAccKmsCryptoKeyVersionWithSymmetricHSM [Debug log]
TestAccKmsCryptoKeyVersion_basic [Debug log]
TestAccKmsCryptoKeyVersion_externalProtectionLevelOptions [Debug log]
TestAccKmsCryptoKeyVersion_patch [Debug log]
TestAccKmsCryptoKeyVersion_skipInitialVersion [Debug log]
TestAccKmsCryptoKey_basic [Debug log]
TestAccKmsCryptoKey_destroyDuration [Debug log]
TestAccKmsCryptoKey_importOnly [Debug log]
TestAccKmsCryptoKey_template [Debug log]
TestAccKmsKeyRingIamBinding [Debug log]
TestAccKmsKeyRingIamBinding_withCondition [Debug log]
TestAccKmsKeyRingIamMember [Debug log]
TestAccKmsKeyRingIamMember_withCondition [Debug log]
TestAccKmsKeyRingIamPolicy [Debug log]
TestAccKmsKeyRingIamPolicy_withCondition [Debug log]
TestAccKmsKeyRing_basic [Debug log]
TestAccLoggingBucketConfigProject_cmekSettings [Debug log]
TestAccLoggingFolderSettings_update [Debug log]
TestAccLoggingProjectCmekSettings_basic [Debug log]
TestAccLoggingProjectSettings_datasource [Debug log]
TestAccLoggingProjectSink_basic [Debug log]
TestAccLoggingProjectSink_default [Debug log]
TestAccServiceNetworkingConnection_abandon [Debug log]
TestAccServiceNetworkingConnection_create [Debug log]
TestAccServiceNetworkingConnection_update [Debug log]
TestAccServiceNetworkingConnection_updateOnCreationFail [Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic [Debug log]
TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewCrossProjectExample [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample [Error message] [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update [Error message] [Debug log]
TestAccApigeeEnvironmentIamBindingGenerated [Error message] [Debug log]
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccComputeProjectMetadata_basic [Error message] [Debug log]
TestAccComputeRegionSecurityPolicy_regionSecurityPolicyWithRulesNetworkMatch [Error message] [Debug log]
TestAccComputeSharedVpc_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccKmsCryptoKey_keyAccessJustificationsPolicy [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceFromMachineImage_terminationTime [Debug log]
TestAccComputeInstanceFromTemplate_TerminationTime [Debug log]
TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccComputeInstance_schedulingTerminationTime [Debug log]
TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildFullExample [Debug log]
TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildMinimalExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4747
Passed tests: 4293
Skipped tests: 439
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccProvider_external_credentials_upgrade

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update
  • TestAccCloudbuildWorkerPool_basic
  • TestAccComputeInstanceFromMachineImage_terminationTime
  • TestAccComputeInstanceFromTemplate_TerminationTime
  • TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime
  • TestAccComputeInstance_schedulingTerminationTime
  • TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildFullExample
  • TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildMinimalExample
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccComputeInstanceFromMachineImage_terminationTime [Debug log]
TestAccComputeInstanceFromTemplate_TerminationTime [Debug log]
TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccComputeInstance_schedulingTerminationTime [Debug log]
TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildFullExample [Debug log]
TestAccFirebaseAppHostingBuild_firebaseAppHostingBuildMinimalExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update [Debug log]
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Debug log]
TestAccApigeeEnvironmentIamBindingGenerated [Debug log]
TestAccApigeeEnvironmentIamMemberGenerated [Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesBetaTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsTestExample [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Debug log]
TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample [Debug log]
TestAccApigeeSyncAuthorization_update [Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTestExample [Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTest_update [Debug log]
TestAccApihubHostProjectRegistration_apihubHostProjectRegistrationBasicExample [Debug log]
TestAccApphubService_apphubServiceBasicExample [Debug log]
TestAccApphubService_apphubServiceFullExample [Debug log]
TestAccApphubService_serviceUpdate [Debug log]
TestAccApphubWorkload_apphubWorkloadBasicExample [Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample [Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate [Debug log]
TestAccBigqueryAnalyticsHubListingSubscription_differentProject [Debug log]
TestAccBinaryAuthorizationPolicy_basic [Debug log]
TestAccBinaryAuthorizationPolicy_full [Debug log]
TestAccBinaryAuthorizationPolicy_separateProject [Debug log]
TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample [Debug log]
TestAccComputeInstanceFromMachineImage_diffProject [Debug log]
TestAccComputeProjectCloudArmorTier_basic [Debug log]
TestAccComputeProjectCloudArmorTier_modify [Debug log]
TestAccComputeProjectDefaultNetworkTier_basic [Debug log]
TestAccComputeProjectDefaultNetworkTier_modify [Debug log]
TestAccComputeProjectMetadata_basic [Debug log]
TestAccComputeProjectMetadata_modify_1 [Debug log]
TestAccComputeProjectMetadata_modify_2 [Debug log]
TestAccComputeRegionSecurityPolicy_regionSecurityPolicyWithRulesNetworkMatch [Debug log]
TestAccComputeResourceUsageExportBucket [Debug log]
TestAccComputeSharedVpc_basic [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinitySpecific [Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivateMultiprojectExample [Debug log]
TestAccDNSPolicy_dnsPolicyMultiprojectExample [Debug log]
TestAccDataSourceApphubDiscoveredService_basic [Debug log]
TestAccDataSourceApphubDiscoveredWorkload_basic [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic [Debug log]
TestAccDialogflowAgent_update [Debug log]
TestAccDialogflowEntityType_update [Debug log]
TestAccDialogflowFulfillment_update [Debug log]
TestAccDialogflowIntent_basic [Debug log]
TestAccDialogflowIntent_dialogflowIntentFullExample [Debug log]
TestAccDialogflowIntent_update [Debug log]
TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseFull [Debug log]
TestAccEventarcGoogleApiSource_update [Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigFullExample [Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigMinimalExample [Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigUpdate [Debug log]
TestAccFirebaseAppCheckRecaptchaEnterpriseConfig_firebaseAppCheckRecaptchaEnterpriseConfigBasicExample [Debug log]
TestAccFirebaseAppCheckRecaptchaEnterpriseConfig_firebaseAppCheckRecaptchaEnterpriseConfigUpdate [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigEnforcedExample [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigOffExample [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUnenforcedExample [Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUpdate [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendFullExample [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendMinimalExample [Debug log]
TestAccFirebaseDataConnectService_Update [Debug log]
TestAccFirebaseDataConnectService_firebasedataconnectServiceBasicExample [Debug log]
TestAccFirebaseDataConnectService_firebasedataconnectServiceWithForceDeletionExample [Debug log]
TestAccFirebaseDatabaseInstance_firebaseDatabaseInstanceDefaultDatabaseExample [Debug log]
TestAccFirestoreDocument_firestoreDocumentBasicExample [Debug log]
TestAccFirestoreDocument_firestoreDocumentNestedDocumentExample [Debug log]
TestAccFirestoreDocument_update [Debug log]
TestAccFirestoreField_firestoreFieldUpdateAddIndexExample [Debug log]
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update [Debug log]
TestAccIapBrand_iapBrandExample [Debug log]
TestAccIapClient_Datasource_basic [Debug log]
TestAccIapClient_iapClientExample [Debug log]
TestAccIapSettings_update [Debug log]
TestAccIapTunnelIamBindingGenerated [Debug log]
TestAccIapTunnelIamBindingGenerated_withCondition [Debug log]
TestAccIapTunnelIamMemberGenerated [Debug log]
TestAccIapTunnelIamMemberGenerated_withCondition [Debug log]
TestAccIapTunnelIamPolicyGenerated [Debug log]
TestAccIapTunnelIamPolicyGenerated_withCondition [Debug log]
TestAccIapWebIamBindingGenerated [Debug log]
TestAccIapWebIamBindingGenerated_withCondition [Debug log]
TestAccIapWebIamMemberGenerated [Debug log]
TestAccIapWebIamMemberGenerated_withCondition [Debug log]
TestAccIapWebIamPolicyGenerated [Debug log]
TestAccIapWebIamPolicyGenerated_withCondition [Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated [Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition [Debug log]
TestAccIapWebTypeAppEngineIamMemberGenerated [Debug log]
TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition [Debug log]
TestAccIapWebTypeAppEngineIamPolicyGenerated [Debug log]
TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition [Debug log]
TestAccIapWebTypeComputeIamBindingGenerated [Debug log]
TestAccIapWebTypeComputeIamBindingGenerated_withCondition [Debug log]
TestAccIapWebTypeComputeIamMemberGenerated [Debug log]
TestAccIapWebTypeComputeIamMemberGenerated_withCondition [Debug log]
TestAccIapWebTypeComputeIamPolicyGenerated [Debug log]
TestAccIapWebTypeComputeIamPolicyGenerated_withCondition [Debug log]
TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample [Debug log]
TestAccIdentityPlatformConfig_identityPlatformConfigWithFalseValuesExample [Debug log]
TestAccLoggingBucketConfigProject_cmekSettings [Debug log]
TestAccLoggingFolderSettings_update [Debug log]
TestAccLoggingProjectCmekSettings_basic [Debug log]
TestAccLoggingProjectSettings_datasource [Debug log]
TestAccLoggingProjectSink_basic [Debug log]
TestAccLoggingProjectSink_default [Debug log]
TestAccServiceNetworkingConnection_abandon [Debug log]
TestAccServiceNetworkingConnection_create [Debug log]
TestAccServiceNetworkingConnection_update [Debug log]
TestAccServiceNetworkingConnection_updateOnCreationFail [Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic [Debug log]
TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewCrossProjectExample [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeAddonsConfig_apigeeAddonsTestExample [Error message] [Debug log]
TestAccBinaryAuthorizationPolicy_update [Error message] [Debug log]
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccComputeSharedReservation_update [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 636 insertions(+), 34 deletions(-))
google-beta provider: Diff ( 10 files changed, 636 insertions(+), 34 deletions(-))

@BBBmau
Copy link
Collaborator Author

BBBmau commented Mar 26, 2025

@c2thorn i've reconfigured the test to be a bit simpler, we see it passing now in this TeamCity Build

running TestAccProvider tests in Teamcity

@BBBmau TestAccProvider_external_credentials_upgrade failed - looks like a formatting issue on the credentials field?

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4748
Passed tests: 4300
Skipped tests: 439
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccProvider_external_credentials_upgrade

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update
  • TestAccCloudbuildWorkerPool_basic
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccLoggingFolderSettings_update
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 667 insertions(+), 34 deletions(-))
google-beta provider: Diff ( 10 files changed, 667 insertions(+), 34 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 667 insertions(+), 34 deletions(-))
google-beta provider: Diff ( 10 files changed, 667 insertions(+), 34 deletions(-))

@c2thorn
Copy link
Member

c2thorn commented Mar 26, 2025

confirmed upgrade test works in latest TC build

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending any issues as the last build runs
VCR failures look unrelated to the change - there are just a lot of existing failures.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4754
Passed tests: 4306
Skipped tests: 439
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccProvider_external_credentials_upgrade

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update
  • TestAccCloudbuildWorkerPool_basic
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccLoggingFolderSettings_update
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4754
Passed tests: 4308
Skipped tests: 439
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccProvider_external_credentials_upgrade

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update
  • TestAccCloudbuildWorkerPool_basic
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudQuotasQuotaPreference_cloudquotasQuotaPreferenceBasicExample_update [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau BBBmau added this pull request to the merge queue Mar 26, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 23516c6 Mar 26, 2025
21 of 22 checks passed
@BBBmau BBBmau deleted the external-credentials-provider branch March 26, 2025 22:45
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
pandirigoog pushed a commit to pandirigoog/magic-modules that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants