add external_credentials support in provider block
#9658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Riley Karson <[email protected]> [upstream:23516c6f5981ddbf9248a3ea1528b08602eb8a7e] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
This adds external_credentials support allowing you to implement credentials such as WIF
screenshot shows successful apply with the previous error occurring when commenting out the external_credentials.
provider that was used for testing this feature is found here: BBBmau/terraform-provider-google@caadf43#diff-3f3fc7ca4bb3b70c74628fe4092a22f6540b4367b2ce9f57766def8093a38a07R1612
Validation
Refer to this comment for the most up-to date validation video
2025-01-09.15-00-17.mov
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12714