Skip to content

Add Gemini Logging Setting resource #12892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PerlMonker303
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Add new resources for Gemini Admin Control

`google_gemini_logging_setting`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 28, 2025
@modular-magician modular-magician added service/gemini and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 29, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 846 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1019 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting" "primary" {
  labels = # value needed
}

@PerlMonker303
Copy link
Contributor Author

@ScottSuarez Let me know if there is anything else I'm missing here.

Copy link

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@ScottSuarez
Copy link
Contributor

hi @PerlMonker303 , sorry for the late comment. I've fallen a bit behind on reviews lately

@ScottSuarez ScottSuarez added this pull request to the merge queue Jan 31, 2025
Merged via the queue into GoogleCloudPlatform:main with commit d8be7da Jan 31, 2025
13 of 14 checks passed
PerlMonker303 added a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants