Skip to content

Add Gemini Logging Setting Binding resource #12893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PerlMonker303
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Add new resources for Gemini Admin Control

`google_gemini_logging_setting_binding`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 28, 2025
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 29, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 761 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 966 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting_binding" "primary" {
  labels  = # value needed
  product = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 7
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@PerlMonker303
Copy link
Contributor Author

Currently failing because it depends on Gemini Logging Setting. Will fix after PR is submitted #12892.

Copy link

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just want to see the test passing now that the blocking PR is merged. Thanks!

melinath and others added 13 commits February 3, 2025 09:32
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 167 insertions(+), 708 deletions(-))
google-beta provider: Diff ( 9 files changed, 873 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_gemini_logging_setting was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the main change in LoggingSetting.yaml is already in the codebase, please revert and make the doc changes in another PR (we generally try to keep PRs to one topic, like adding a single new resource as in this PR).

Otherwise, LGTM - I'll approve and merge once that's done. Thanks!

@github-actions github-actions bot requested a review from SirGitsalot February 10, 2025 09:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 157 insertions(+))
google-beta provider: Diff ( 8 files changed, 859 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@PerlMonker303
Copy link
Contributor Author

Created #13015 with description changes as suggested in the comment above.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 157 insertions(+))
google-beta provider: Diff ( 8 files changed, 859 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini

🟢 All tests passed!

View the build log

@PerlMonker303
Copy link
Contributor Author

Can be reviewed.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 158 insertions(+))
google-beta provider: Diff ( 8 files changed, 858 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini

🟢 All tests passed!

View the build log

@SirGitsalot SirGitsalot added this pull request to the merge queue Feb 11, 2025
Merged via the queue into GoogleCloudPlatform:main with commit eb11258 Feb 11, 2025
21 of 22 checks passed
Dawid212 added a commit to Dawid212/magic-modules that referenced this pull request Feb 12, 2025
Signed-off-by: Martijn Stevenson <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Akshat Jindal <[email protected]>
Co-authored-by: Sam Levenick <[email protected]>
Co-authored-by: abheda-crest <[email protected]>
Co-authored-by: karolgorc <[email protected]>
Co-authored-by: aniket gupta <[email protected]>
Co-authored-by: Chris Stephens <[email protected]>
Co-authored-by: hao-nan-li <[email protected]>
Co-authored-by: Ankit Goyal <[email protected]>
Co-authored-by: bcreddy-gcp <[email protected]>
Co-authored-by: bestefreund <[email protected]>
Co-authored-by: NA2047 <[email protected]>
Co-authored-by: Dhruv Agarwal <[email protected]>
Co-authored-by: Will Yardley <[email protected]>
Co-authored-by: Chenhao Ma <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Andras Kerekes <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Nikhil Bhoyar <[email protected]>
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
Co-authored-by: Lagu22 <[email protected]>
Co-authored-by: Chris Hawk <[email protected]>
Co-authored-by: Jared <[email protected]>
Co-authored-by: Daniel Dubnikov <[email protected]>
Co-authored-by: Dawid212 <[email protected]>
Co-authored-by: Andrea Lee <[email protected]>
Co-authored-by: Damon <[email protected]>
Co-authored-by: askubis <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: coder-221 <[email protected]>
Co-authored-by: Betto Cerrillos <[email protected]>
Co-authored-by: wj-chen <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Amit <[email protected]>
Co-authored-by: martijneken <[email protected]>
Co-authored-by: Zeleena Kearney <[email protected]>
Co-authored-by: Cameron Moberg <[email protected]>
Co-authored-by: cesteve <[email protected]>
Co-authored-by: vijaykanthm <[email protected]>
Co-authored-by: alkobi-google <[email protected]>
Co-authored-by: nityaravi <[email protected]>
Co-authored-by: Obada Alabbadi <[email protected]>
Co-authored-by: cslink <[email protected]>
Co-authored-by: Bob "Wombat" Hogg <[email protected]>
Co-authored-by: Terje Larsen <[email protected]>
Co-authored-by: Maksym Fuhol <[email protected]>
Co-authored-by: Benyamin Bashari <[email protected]>
Co-authored-by: gurankitt <[email protected]>
Co-authored-by: rahul2393 <[email protected]>
Co-authored-by: dsafdsa1 <[email protected]>
Co-authored-by: wafrelka <[email protected]>
Co-authored-by: Kevin-Looong <[email protected]>
Co-authored-by: Kevin Long <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>
Co-authored-by: gvijbha <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Arun Satyarth <[email protected]>
Co-authored-by: asatyarth <[email protected]>
Co-authored-by: Sander van Donkelaar <[email protected]>
Co-authored-by: 7mako <[email protected]>
Co-authored-by: Xylosma <[email protected]>
Co-authored-by: Angelina Shibu <[email protected]>
Co-authored-by: Nahur Fonseca <[email protected]>
Co-authored-by: mihhalj <[email protected]>
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Signed-off-by: Martijn Stevenson <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Akshat Jindal <[email protected]>
Co-authored-by: Sam Levenick <[email protected]>
Co-authored-by: abheda-crest <[email protected]>
Co-authored-by: karolgorc <[email protected]>
Co-authored-by: aniket gupta <[email protected]>
Co-authored-by: Chris Stephens <[email protected]>
Co-authored-by: hao-nan-li <[email protected]>
Co-authored-by: Ankit Goyal <[email protected]>
Co-authored-by: bcreddy-gcp <[email protected]>
Co-authored-by: bestefreund <[email protected]>
Co-authored-by: NA2047 <[email protected]>
Co-authored-by: Dhruv Agarwal <[email protected]>
Co-authored-by: Will Yardley <[email protected]>
Co-authored-by: Chenhao Ma <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Andras Kerekes <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Nikhil Bhoyar <[email protected]>
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
Co-authored-by: Lagu22 <[email protected]>
Co-authored-by: Chris Hawk <[email protected]>
Co-authored-by: Jared <[email protected]>
Co-authored-by: Daniel Dubnikov <[email protected]>
Co-authored-by: Dawid212 <[email protected]>
Co-authored-by: Andrea Lee <[email protected]>
Co-authored-by: Damon <[email protected]>
Co-authored-by: askubis <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: coder-221 <[email protected]>
Co-authored-by: Betto Cerrillos <[email protected]>
Co-authored-by: wj-chen <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Amit <[email protected]>
Co-authored-by: martijneken <[email protected]>
Co-authored-by: Zeleena Kearney <[email protected]>
Co-authored-by: Cameron Moberg <[email protected]>
Co-authored-by: cesteve <[email protected]>
Co-authored-by: vijaykanthm <[email protected]>
Co-authored-by: alkobi-google <[email protected]>
Co-authored-by: nityaravi <[email protected]>
Co-authored-by: Obada Alabbadi <[email protected]>
Co-authored-by: cslink <[email protected]>
Co-authored-by: Bob "Wombat" Hogg <[email protected]>
Co-authored-by: Terje Larsen <[email protected]>
Co-authored-by: Maksym Fuhol <[email protected]>
Co-authored-by: Benyamin Bashari <[email protected]>
Co-authored-by: gurankitt <[email protected]>
Co-authored-by: rahul2393 <[email protected]>
Co-authored-by: dsafdsa1 <[email protected]>
Co-authored-by: wafrelka <[email protected]>
Co-authored-by: Kevin-Looong <[email protected]>
Co-authored-by: Kevin Long <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>
Co-authored-by: gvijbha <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Arun Satyarth <[email protected]>
Co-authored-by: asatyarth <[email protected]>
Co-authored-by: Sander van Donkelaar <[email protected]>
Co-authored-by: 7mako <[email protected]>
Co-authored-by: Xylosma <[email protected]>
Co-authored-by: Angelina Shibu <[email protected]>
Co-authored-by: Nahur Fonseca <[email protected]>
Co-authored-by: mihhalj <[email protected]>
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
Signed-off-by: Martijn Stevenson <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Akshat Jindal <[email protected]>
Co-authored-by: Sam Levenick <[email protected]>
Co-authored-by: abheda-crest <[email protected]>
Co-authored-by: karolgorc <[email protected]>
Co-authored-by: aniket gupta <[email protected]>
Co-authored-by: Chris Stephens <[email protected]>
Co-authored-by: hao-nan-li <[email protected]>
Co-authored-by: Ankit Goyal <[email protected]>
Co-authored-by: bcreddy-gcp <[email protected]>
Co-authored-by: bestefreund <[email protected]>
Co-authored-by: NA2047 <[email protected]>
Co-authored-by: Dhruv Agarwal <[email protected]>
Co-authored-by: Will Yardley <[email protected]>
Co-authored-by: Chenhao Ma <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Andras Kerekes <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Nikhil Bhoyar <[email protected]>
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
Co-authored-by: Lagu22 <[email protected]>
Co-authored-by: Chris Hawk <[email protected]>
Co-authored-by: Jared <[email protected]>
Co-authored-by: Daniel Dubnikov <[email protected]>
Co-authored-by: Dawid212 <[email protected]>
Co-authored-by: Andrea Lee <[email protected]>
Co-authored-by: Damon <[email protected]>
Co-authored-by: askubis <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: coder-221 <[email protected]>
Co-authored-by: Betto Cerrillos <[email protected]>
Co-authored-by: wj-chen <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Amit <[email protected]>
Co-authored-by: martijneken <[email protected]>
Co-authored-by: Zeleena Kearney <[email protected]>
Co-authored-by: Cameron Moberg <[email protected]>
Co-authored-by: cesteve <[email protected]>
Co-authored-by: vijaykanthm <[email protected]>
Co-authored-by: alkobi-google <[email protected]>
Co-authored-by: nityaravi <[email protected]>
Co-authored-by: Obada Alabbadi <[email protected]>
Co-authored-by: cslink <[email protected]>
Co-authored-by: Bob "Wombat" Hogg <[email protected]>
Co-authored-by: Terje Larsen <[email protected]>
Co-authored-by: Maksym Fuhol <[email protected]>
Co-authored-by: Benyamin Bashari <[email protected]>
Co-authored-by: gurankitt <[email protected]>
Co-authored-by: rahul2393 <[email protected]>
Co-authored-by: dsafdsa1 <[email protected]>
Co-authored-by: wafrelka <[email protected]>
Co-authored-by: Kevin-Looong <[email protected]>
Co-authored-by: Kevin Long <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>
Co-authored-by: gvijbha <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Arun Satyarth <[email protected]>
Co-authored-by: asatyarth <[email protected]>
Co-authored-by: Sander van Donkelaar <[email protected]>
Co-authored-by: 7mako <[email protected]>
Co-authored-by: Xylosma <[email protected]>
Co-authored-by: Angelina Shibu <[email protected]>
Co-authored-by: Nahur Fonseca <[email protected]>
Co-authored-by: mihhalj <[email protected]>
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Signed-off-by: Martijn Stevenson <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Akshat Jindal <[email protected]>
Co-authored-by: Sam Levenick <[email protected]>
Co-authored-by: abheda-crest <[email protected]>
Co-authored-by: karolgorc <[email protected]>
Co-authored-by: aniket gupta <[email protected]>
Co-authored-by: Chris Stephens <[email protected]>
Co-authored-by: hao-nan-li <[email protected]>
Co-authored-by: Ankit Goyal <[email protected]>
Co-authored-by: bcreddy-gcp <[email protected]>
Co-authored-by: bestefreund <[email protected]>
Co-authored-by: NA2047 <[email protected]>
Co-authored-by: Dhruv Agarwal <[email protected]>
Co-authored-by: Will Yardley <[email protected]>
Co-authored-by: Chenhao Ma <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Andras Kerekes <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Nikhil Bhoyar <[email protected]>
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
Co-authored-by: Lagu22 <[email protected]>
Co-authored-by: Chris Hawk <[email protected]>
Co-authored-by: Jared <[email protected]>
Co-authored-by: Daniel Dubnikov <[email protected]>
Co-authored-by: Dawid212 <[email protected]>
Co-authored-by: Andrea Lee <[email protected]>
Co-authored-by: Damon <[email protected]>
Co-authored-by: askubis <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: coder-221 <[email protected]>
Co-authored-by: Betto Cerrillos <[email protected]>
Co-authored-by: wj-chen <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Amit <[email protected]>
Co-authored-by: martijneken <[email protected]>
Co-authored-by: Zeleena Kearney <[email protected]>
Co-authored-by: Cameron Moberg <[email protected]>
Co-authored-by: cesteve <[email protected]>
Co-authored-by: vijaykanthm <[email protected]>
Co-authored-by: alkobi-google <[email protected]>
Co-authored-by: nityaravi <[email protected]>
Co-authored-by: Obada Alabbadi <[email protected]>
Co-authored-by: cslink <[email protected]>
Co-authored-by: Bob "Wombat" Hogg <[email protected]>
Co-authored-by: Terje Larsen <[email protected]>
Co-authored-by: Maksym Fuhol <[email protected]>
Co-authored-by: Benyamin Bashari <[email protected]>
Co-authored-by: gurankitt <[email protected]>
Co-authored-by: rahul2393 <[email protected]>
Co-authored-by: dsafdsa1 <[email protected]>
Co-authored-by: wafrelka <[email protected]>
Co-authored-by: Kevin-Looong <[email protected]>
Co-authored-by: Kevin Long <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>
Co-authored-by: gvijbha <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Arun Satyarth <[email protected]>
Co-authored-by: asatyarth <[email protected]>
Co-authored-by: Sander van Donkelaar <[email protected]>
Co-authored-by: 7mako <[email protected]>
Co-authored-by: Xylosma <[email protected]>
Co-authored-by: Angelina Shibu <[email protected]>
Co-authored-by: Nahur Fonseca <[email protected]>
Co-authored-by: mihhalj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.