-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add Gemini Logging Setting Binding resource #12893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gemini Logging Setting Binding resource #12893
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gemini_logging_setting_binding" "primary" {
labels = # value needed
product = # value needed
}
|
Tests analyticsTotal tests: 9 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Currently failing because it depends on Gemini Logging Setting. Will fix after PR is submitted #12892. |
@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just want to see the test passing now that the blocking PR is merged. Thanks!
…oogleCloudPlatform#12762) Co-authored-by: Luca Prete <[email protected]>
…loudPlatform#12355) Co-authored-by: Sam Levenick <[email protected]>
…ter_manager_parameter` (GoogleCloudPlatform#12639)
…gle_parameter_manager_regional_parameters` (GoogleCloudPlatform#12651)
Tests analyticsTotal tests: 15 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 15 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the main change in LoggingSetting.yaml is already in the codebase, please revert and make the doc changes in another PR (we generally try to keep PRs to one topic, like adding a single new resource as in this PR).
Otherwise, LGTM - I'll approve and merge once that's done. Thanks!
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Created #13015 with description changes as suggested in the comment above. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 15 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 15 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Can be reviewed. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 15 Click here to see the affected service packages
🟢 All tests passed! View the build log |
eb11258
Signed-off-by: Martijn Stevenson <[email protected]> Signed-off-by: alkobi-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Akshat Jindal <[email protected]> Co-authored-by: Sam Levenick <[email protected]> Co-authored-by: abheda-crest <[email protected]> Co-authored-by: karolgorc <[email protected]> Co-authored-by: aniket gupta <[email protected]> Co-authored-by: Chris Stephens <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Ankit Goyal <[email protected]> Co-authored-by: bcreddy-gcp <[email protected]> Co-authored-by: bestefreund <[email protected]> Co-authored-by: NA2047 <[email protected]> Co-authored-by: Dhruv Agarwal <[email protected]> Co-authored-by: Will Yardley <[email protected]> Co-authored-by: Chenhao Ma <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Nick Elliot <[email protected]> Co-authored-by: Andras Kerekes <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Nikhil Bhoyar <[email protected]> Co-authored-by: Wiktor Niesiobędzki <[email protected]> Co-authored-by: Lagu22 <[email protected]> Co-authored-by: Chris Hawk <[email protected]> Co-authored-by: Jared <[email protected]> Co-authored-by: Daniel Dubnikov <[email protected]> Co-authored-by: Dawid212 <[email protected]> Co-authored-by: Andrea Lee <[email protected]> Co-authored-by: Damon <[email protected]> Co-authored-by: askubis <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: coder-221 <[email protected]> Co-authored-by: Betto Cerrillos <[email protected]> Co-authored-by: wj-chen <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Amit <[email protected]> Co-authored-by: martijneken <[email protected]> Co-authored-by: Zeleena Kearney <[email protected]> Co-authored-by: Cameron Moberg <[email protected]> Co-authored-by: cesteve <[email protected]> Co-authored-by: vijaykanthm <[email protected]> Co-authored-by: alkobi-google <[email protected]> Co-authored-by: nityaravi <[email protected]> Co-authored-by: Obada Alabbadi <[email protected]> Co-authored-by: cslink <[email protected]> Co-authored-by: Bob "Wombat" Hogg <[email protected]> Co-authored-by: Terje Larsen <[email protected]> Co-authored-by: Maksym Fuhol <[email protected]> Co-authored-by: Benyamin Bashari <[email protected]> Co-authored-by: gurankitt <[email protected]> Co-authored-by: rahul2393 <[email protected]> Co-authored-by: dsafdsa1 <[email protected]> Co-authored-by: wafrelka <[email protected]> Co-authored-by: Kevin-Looong <[email protected]> Co-authored-by: Kevin Long <[email protected]> Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: gvijbha <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Arun Satyarth <[email protected]> Co-authored-by: asatyarth <[email protected]> Co-authored-by: Sander van Donkelaar <[email protected]> Co-authored-by: 7mako <[email protected]> Co-authored-by: Xylosma <[email protected]> Co-authored-by: Angelina Shibu <[email protected]> Co-authored-by: Nahur Fonseca <[email protected]> Co-authored-by: mihhalj <[email protected]>
Signed-off-by: Martijn Stevenson <[email protected]> Signed-off-by: alkobi-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Akshat Jindal <[email protected]> Co-authored-by: Sam Levenick <[email protected]> Co-authored-by: abheda-crest <[email protected]> Co-authored-by: karolgorc <[email protected]> Co-authored-by: aniket gupta <[email protected]> Co-authored-by: Chris Stephens <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Ankit Goyal <[email protected]> Co-authored-by: bcreddy-gcp <[email protected]> Co-authored-by: bestefreund <[email protected]> Co-authored-by: NA2047 <[email protected]> Co-authored-by: Dhruv Agarwal <[email protected]> Co-authored-by: Will Yardley <[email protected]> Co-authored-by: Chenhao Ma <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Nick Elliot <[email protected]> Co-authored-by: Andras Kerekes <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Nikhil Bhoyar <[email protected]> Co-authored-by: Wiktor Niesiobędzki <[email protected]> Co-authored-by: Lagu22 <[email protected]> Co-authored-by: Chris Hawk <[email protected]> Co-authored-by: Jared <[email protected]> Co-authored-by: Daniel Dubnikov <[email protected]> Co-authored-by: Dawid212 <[email protected]> Co-authored-by: Andrea Lee <[email protected]> Co-authored-by: Damon <[email protected]> Co-authored-by: askubis <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: coder-221 <[email protected]> Co-authored-by: Betto Cerrillos <[email protected]> Co-authored-by: wj-chen <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Amit <[email protected]> Co-authored-by: martijneken <[email protected]> Co-authored-by: Zeleena Kearney <[email protected]> Co-authored-by: Cameron Moberg <[email protected]> Co-authored-by: cesteve <[email protected]> Co-authored-by: vijaykanthm <[email protected]> Co-authored-by: alkobi-google <[email protected]> Co-authored-by: nityaravi <[email protected]> Co-authored-by: Obada Alabbadi <[email protected]> Co-authored-by: cslink <[email protected]> Co-authored-by: Bob "Wombat" Hogg <[email protected]> Co-authored-by: Terje Larsen <[email protected]> Co-authored-by: Maksym Fuhol <[email protected]> Co-authored-by: Benyamin Bashari <[email protected]> Co-authored-by: gurankitt <[email protected]> Co-authored-by: rahul2393 <[email protected]> Co-authored-by: dsafdsa1 <[email protected]> Co-authored-by: wafrelka <[email protected]> Co-authored-by: Kevin-Looong <[email protected]> Co-authored-by: Kevin Long <[email protected]> Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: gvijbha <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Arun Satyarth <[email protected]> Co-authored-by: asatyarth <[email protected]> Co-authored-by: Sander van Donkelaar <[email protected]> Co-authored-by: 7mako <[email protected]> Co-authored-by: Xylosma <[email protected]> Co-authored-by: Angelina Shibu <[email protected]> Co-authored-by: Nahur Fonseca <[email protected]> Co-authored-by: mihhalj <[email protected]>
Signed-off-by: Martijn Stevenson <[email protected]> Signed-off-by: alkobi-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Akshat Jindal <[email protected]> Co-authored-by: Sam Levenick <[email protected]> Co-authored-by: abheda-crest <[email protected]> Co-authored-by: karolgorc <[email protected]> Co-authored-by: aniket gupta <[email protected]> Co-authored-by: Chris Stephens <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Ankit Goyal <[email protected]> Co-authored-by: bcreddy-gcp <[email protected]> Co-authored-by: bestefreund <[email protected]> Co-authored-by: NA2047 <[email protected]> Co-authored-by: Dhruv Agarwal <[email protected]> Co-authored-by: Will Yardley <[email protected]> Co-authored-by: Chenhao Ma <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Nick Elliot <[email protected]> Co-authored-by: Andras Kerekes <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Nikhil Bhoyar <[email protected]> Co-authored-by: Wiktor Niesiobędzki <[email protected]> Co-authored-by: Lagu22 <[email protected]> Co-authored-by: Chris Hawk <[email protected]> Co-authored-by: Jared <[email protected]> Co-authored-by: Daniel Dubnikov <[email protected]> Co-authored-by: Dawid212 <[email protected]> Co-authored-by: Andrea Lee <[email protected]> Co-authored-by: Damon <[email protected]> Co-authored-by: askubis <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: coder-221 <[email protected]> Co-authored-by: Betto Cerrillos <[email protected]> Co-authored-by: wj-chen <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Amit <[email protected]> Co-authored-by: martijneken <[email protected]> Co-authored-by: Zeleena Kearney <[email protected]> Co-authored-by: Cameron Moberg <[email protected]> Co-authored-by: cesteve <[email protected]> Co-authored-by: vijaykanthm <[email protected]> Co-authored-by: alkobi-google <[email protected]> Co-authored-by: nityaravi <[email protected]> Co-authored-by: Obada Alabbadi <[email protected]> Co-authored-by: cslink <[email protected]> Co-authored-by: Bob "Wombat" Hogg <[email protected]> Co-authored-by: Terje Larsen <[email protected]> Co-authored-by: Maksym Fuhol <[email protected]> Co-authored-by: Benyamin Bashari <[email protected]> Co-authored-by: gurankitt <[email protected]> Co-authored-by: rahul2393 <[email protected]> Co-authored-by: dsafdsa1 <[email protected]> Co-authored-by: wafrelka <[email protected]> Co-authored-by: Kevin-Looong <[email protected]> Co-authored-by: Kevin Long <[email protected]> Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: gvijbha <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Arun Satyarth <[email protected]> Co-authored-by: asatyarth <[email protected]> Co-authored-by: Sander van Donkelaar <[email protected]> Co-authored-by: 7mako <[email protected]> Co-authored-by: Xylosma <[email protected]> Co-authored-by: Angelina Shibu <[email protected]> Co-authored-by: Nahur Fonseca <[email protected]> Co-authored-by: mihhalj <[email protected]>
Signed-off-by: Martijn Stevenson <[email protected]> Signed-off-by: alkobi-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Akshat Jindal <[email protected]> Co-authored-by: Sam Levenick <[email protected]> Co-authored-by: abheda-crest <[email protected]> Co-authored-by: karolgorc <[email protected]> Co-authored-by: aniket gupta <[email protected]> Co-authored-by: Chris Stephens <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Ankit Goyal <[email protected]> Co-authored-by: bcreddy-gcp <[email protected]> Co-authored-by: bestefreund <[email protected]> Co-authored-by: NA2047 <[email protected]> Co-authored-by: Dhruv Agarwal <[email protected]> Co-authored-by: Will Yardley <[email protected]> Co-authored-by: Chenhao Ma <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Nick Elliot <[email protected]> Co-authored-by: Andras Kerekes <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Nikhil Bhoyar <[email protected]> Co-authored-by: Wiktor Niesiobędzki <[email protected]> Co-authored-by: Lagu22 <[email protected]> Co-authored-by: Chris Hawk <[email protected]> Co-authored-by: Jared <[email protected]> Co-authored-by: Daniel Dubnikov <[email protected]> Co-authored-by: Dawid212 <[email protected]> Co-authored-by: Andrea Lee <[email protected]> Co-authored-by: Damon <[email protected]> Co-authored-by: askubis <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: coder-221 <[email protected]> Co-authored-by: Betto Cerrillos <[email protected]> Co-authored-by: wj-chen <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Amit <[email protected]> Co-authored-by: martijneken <[email protected]> Co-authored-by: Zeleena Kearney <[email protected]> Co-authored-by: Cameron Moberg <[email protected]> Co-authored-by: cesteve <[email protected]> Co-authored-by: vijaykanthm <[email protected]> Co-authored-by: alkobi-google <[email protected]> Co-authored-by: nityaravi <[email protected]> Co-authored-by: Obada Alabbadi <[email protected]> Co-authored-by: cslink <[email protected]> Co-authored-by: Bob "Wombat" Hogg <[email protected]> Co-authored-by: Terje Larsen <[email protected]> Co-authored-by: Maksym Fuhol <[email protected]> Co-authored-by: Benyamin Bashari <[email protected]> Co-authored-by: gurankitt <[email protected]> Co-authored-by: rahul2393 <[email protected]> Co-authored-by: dsafdsa1 <[email protected]> Co-authored-by: wafrelka <[email protected]> Co-authored-by: Kevin-Looong <[email protected]> Co-authored-by: Kevin Long <[email protected]> Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: gvijbha <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Arun Satyarth <[email protected]> Co-authored-by: asatyarth <[email protected]> Co-authored-by: Sander van Donkelaar <[email protected]> Co-authored-by: 7mako <[email protected]> Co-authored-by: Xylosma <[email protected]> Co-authored-by: Angelina Shibu <[email protected]> Co-authored-by: Nahur Fonseca <[email protected]> Co-authored-by: mihhalj <[email protected]>
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Add new resources for Gemini Admin Control