Add missing field to disks and support InstantSnapshot #12946
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
|
You should be able to add a tar.gz image into our test-fixtures file (for example for the IAP product: https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/services/iap/test-fixtures) and then upload it via a google_storage_object resource |
Seems that it doesn't matter. It doesn't force replace
|
karolgorc
force-pushed
the
feature/disks-gap
branch
from
9dc099c to
4d47a13
Compare
Interesting! Can you add an update test for labels then? |
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
modular-magician
added
service/compute-pd
and removed
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instant_snapshot" "primary" {
description = # value needed
labels = # value needed
}
Resource: resource "google_compute_instant_snapshot_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_compute_instant_snapshot_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: 1111 Click here to see the affected service packages
Action takenFound 84 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Don't have access to the test logs, "403 forbidden". So some of these failed here but pass in my local env. Can i get the logs for them if they fail after a rerun?
Found a permadiff case with the field "architecture" - fixed - this caused all the Disk tests to fail |
modular-magician
added
the
awaiting-approval
mmv1/third_party/terraform/services/compute/resource_compute_instant_snapshot_test.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/compute/resource_compute_instant_snapshot_test.go.tmpl
Outdated
Show resolved
Hide resolved
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1120 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
The disk had a wrong name in the |
karolgorc
force-pushed
the
feature/disks-gap
branch
from
a433612 to
bd19738
Compare
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1120 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
karolgorc
force-pushed
the
feature/disks-gap
branch
from
bd19738 to
60de515
Compare
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1120 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
|
Is there anything that has to be done with this? |
f3ff113
closes hashicorp/terraform-provider-google#16426
Added some missing fields to
google_compute_disk. One of them issourceInstantSnapshotso i've added the resource to create instant snapshots into terraform.One thing i'm having trouble testing is
sourceStorageObject. It requires a Bucket with an image stored as*.tar.gz. Only way i've found of recreating this in an acceptance test is usinggcloud image exportinto the bucket but don't know if we want something like that in our tests. Please LMK!Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.