Add missing field to disks and support InstantSnapshot #3513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:f3ff113ecc22a77cf3678c80cde0a46ecbfa9aa3] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
kotatut
pushed a commit
to kotatut/terraform-google-conversion-antonkot
that referenced
this pull request
Apr 18, 2025
…leCloudPlatform#3513) [upstream:f3ff113ecc22a77cf3678c80cde0a46ecbfa9aa3] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#16426
Added some missing fields to
google_compute_disk. One of them issourceInstantSnapshotso i've added the resource to create instant snapshots into terraform.One thing i'm having trouble testing is
sourceStorageObject. It requires a Bucket with an image stored as*.tar.gz. Only way i've found of recreating this in an acceptance test is usinggcloud image exportinto the bucket but don't know if we want something like that in our tests. Please LMK!Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12946