Added IAP Enable/Disable flag in cloudrunv2 service

[Deepraj1996]

cloudrunv2: added `iap_enabled` field to `google_cloud_run_v2_service` (beta).

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[SirGitsalot]

/gcbrun

[Deepraj1996]

/gcbrun

Hi @SirGitsalot, I see a few PR checks were cancelled/skipped. Could you please rerun those?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 177 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 53
Passed tests: 46
Skipped tests: 5
Affected tests: 2

Click here to see the affected service packages

• cloudrunv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudRunV2Service_cloudrunv2ServiceIapExample
• TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceIapExample [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[SirGitsalot]

LGTM - I manually kicked off the integration tests, you'll need to sign the CLA (even as a Googler) for the next step

[yanweiguo]

iap_enabled field is not in Cloud Run v2 api yet: https://cloud.google.com/run/docs/reference/rest/v2/projects.locations.services

I wonder how it would work.

[Deepraj1996]

iap_enabled field is not in Cloud Run v2 api yet: https://cloud.google.com/run/docs/reference/rest/v2/projects.locations.services

I wonder how it would work.

Hi @yanweiguo, iap_enabled flag visibility is hidden from public doc

[Deepraj1996]

LGTM - I manually kicked off the integration tests, you'll need to sign the CLA (even as a Googler) for the next step

Hi @SirGitsalot , I have a CLA issue as I am from xWF, this PR will be cloned by Google team member and submitted on his behalf.

[yanweiguo]

iap_enabled field is not in Cloud Run v2 api yet: https://cloud.google.com/run/docs/reference/rest/v2/projects.locations.services
I wonder how it would work.

Hi @yanweiguo, iap_enabled flag visibility is hidden from public doc

Right, I think the visibility limit should be removed first otherwise the setting for this field will be ignored by Cloud Run API.

[SirGitsalot]

Yeah, we'll want to wait until the field is publicly available to merge. FWIW, the tests are able to set and retrieve the field, but that's likely because the service account that the tests run as has previously been granted visibility access to the label.

[github-actions]

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[SirGitsalot]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 177 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 53
Passed tests: 46
Skipped tests: 5
Affected tests: 2

Click here to see the affected service packages

• cloudrunv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample
• TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[SirGitsalot]

The other PR is merged, feel free to delete this PR. Thanks!