Skip to content

Added IAP Enable/Disable flag in cloudrunv2 service. #13575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

bryan0515
Copy link
Contributor

@bryan0515 bryan0515 commented Apr 7, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrunv2: added `iapEnabled` field to `mmv1/products/cloudrunv2/Service.yaml` resource

This PR is cloned from #12965

@github-actions github-actions bot requested a review from SirGitsalot April 7, 2025 21:52
Copy link

github-actions bot commented Apr 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 53 insertions(+))
google-beta provider: Diff ( 8 files changed, 334 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 72
Skipped tests: 11
Affected tests: 4

Click here to see the affected service packages
  • cloudrun
  • cloudrunv2

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceIapExample
  • TestAccCloudRunService_cloudRunServiceIap_update
  • TestAccCloudRunV2Service_cloudrunv2ServiceIapExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceIapExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceIap_update [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 177 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 46
Skipped tests: 5
Affected tests: 2

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceIapExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceIapExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from SirGitsalot April 9, 2025 23:21
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 176 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 45
Skipped tests: 5
Affected tests: 3

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update
  • TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants