Skip to content

make authz extension wire_format O+C #12975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Feb 5, 2025

fixes hashicorp/terraform-provider-google#21129
fixes hashicorp/terraform-provider-google#21120
fixes hashicorp/terraform-provider-google#21180
fixes hashicorp/terraform-provider-google#21171

not sure if the API changed behavior since resource implementation, but the API no longer accepts the provider supplying the default value. Changing the field to be O+C to allow the API to set the default itself.

Should not be a breaking change due to making it O+C while also moving away from a default that is just straight up invalid.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkservices: fixed a bug with `google_network_services_authz_extension.wire_format` sending an invalid default value by removing the Terraform default and letting the API set the default.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 8 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field wire_format default value changed from EXT_PROC_GRPC to on google_network_services_authz_extension - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 57
Passed tests: 54
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionBasicExample
  • TestAccNetworkServicesAuthzExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesAuthzExtension_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 3 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 9 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field wire_format default value changed from EXT_PROC_GRPC to on google_network_services_authz_extension - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_authz_extension (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_authz_extension" "primary" {
  wire_format = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 57
Passed tests: 55
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesAuthzExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesAuthzExtension_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 3 files changed, 25 insertions(+), 31 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field wire_format default value changed from EXT_PROC_GRPC to on google_network_services_authz_extension - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_authz_extension (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_authz_extension" "primary" {
  wire_format = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 57
Passed tests: 55
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesAuthzExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesAuthzExtension_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@c2thorn
Copy link
Member Author

c2thorn commented Feb 6, 2025

@modular-magician reassign-reviewer

@c2thorn c2thorn added the override-breaking-change Allows a potential breaking change to be merged label Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from slevenick February 6, 2025 16:53
@@ -47,21 +47,21 @@ func TestAccNetworkServicesAuthzExtension_update(t *testing.T) {
func testAccNetworkServicesAuthzExtension_start(context map[string]interface{}) string {
return acctest.Nprintf(`
resource "google_compute_network" "default" {
name = "lb-network"
name = "lb-network%{random_suffix}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change these to tf-test...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 3 files changed, 25 insertions(+), 31 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field wire_format default value changed from EXT_PROC_GRPC to on google_network_services_authz_extension - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_authz_extension (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_authz_extension" "primary" {
  wire_format = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 57
Passed tests: 55
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesAuthzExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesAuthzExtension_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something strange happened with generation, can you repush?

@c2thorn c2thorn force-pushed the network-services-authz-extension-wire-format branch from 2928502 to 38aae77 Compare February 6, 2025 17:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 3 files changed, 25 insertions(+), 31 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field wire_format default value changed from EXT_PROC_GRPC to on google_network_services_authz_extension - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_authz_extension (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_authz_extension" "primary" {
  wire_format = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 57
Passed tests: 56
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkservices

🟢 All tests passed!

View the build log

@c2thorn c2thorn added this pull request to the merge queue Feb 6, 2025
Merged via the queue into GoogleCloudPlatform:main with commit b0a90c2 Feb 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment