make authz extension wire_format O+C #3414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:b0a90c2e7fd158a9030db2f2c3d66ea8e39c3ca9] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
iyabchen
and removed request for
a team
modular-magician
merged commit 95427e9
into
GoogleCloudPlatform:main
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes hashicorp/terraform-provider-google#21129
fixes hashicorp/terraform-provider-google#21120
fixes hashicorp/terraform-provider-google#21180
fixes hashicorp/terraform-provider-google#21171
not sure if the API changed behavior since resource implementation, but the API no longer accepts the provider supplying the default value. Changing the field to be O+C to allow the API to set the default itself.
Should not be a breaking change due to making it O+C while also moving away from a default that is just straight up invalid.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12975