spanner: fixed applying default_labels changes

[rickard-von-essen]

Before this fix just changing default_labels on the provider for a google_spanner_instance resulted in this error:

googleapi: Error 400: Invalid UpdateInstance request.
[...]
Must specify a non-empty field mask

Fixes hashicorp/terraform-provider-google#18445

Added one acceptance tests to surface this issue.

• TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels

spanner: fixed issue with applying changes in provider `default_labels` on `google_spanner_instance`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[NickElliot]

one point stood out to me

[rickard-von-essen]

Addressed the review comment and re-executed the acceptance test.

$ make testacc TEST=./google/services/spanner TESTARGS='-run=TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels$$'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/spanner -v -run=TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels$ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels
=== PAUSE TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels
=== CONT  TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels
--- PASS: TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels (60.45s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/spanner  61.089s

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 66 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 66 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 37
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages

• spanner

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

LGTM