Skip to content

spanner: fixed applying default_labels changes #9629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Before this fix just changing default_labels on the provider for a google_spanner_instance resulted in this error:

googleapi: Error 400: Invalid UpdateInstance request.
[...]
Must specify a non-empty field mask

Fixes hashicorp/terraform-provider-google#18445

Added one acceptance tests to surface this issue.

  • TestAccSpannerInstance_basicUpdateWithProviderDefaultLabels
spanner: fixed issue with applying changes in provider `default_labels` on `google_spanner_instance`

Derived from GoogleCloudPlatform/magic-modules#13269

[upstream:b1cca42eed8cdc4d7f4e9f35ce4fb76dcf739adc]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 24, 2025 21:44
@modular-magician modular-magician merged commit 0623bdc into hashicorp:main Mar 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BadRequest error when updating google_spanner_instance with labels set at provider level
1 participant