Adding in automated backup config to memorystore

[NA2047]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

memorystore: added `automated_backup _conf` field to `google_memorystore_instance` resource,

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 444 insertions(+))
google-beta provider: Diff ( 4 files changed, 444 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 122 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  automated_backup_config {
    fixed_frequency_schedule {
      start_time {
        hours   = # value needed
        minutes = # value needed
        nanos   = # value needed
        seconds = # value needed
      }
    }
    retention = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_automatedBackupConfig

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 483 insertions(+))
google-beta provider: Diff ( 4 files changed, 483 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 122 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_automatedBackupConfig

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 483 insertions(+))
google-beta provider: Diff ( 4 files changed, 483 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 122 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_automatedBackupConfig

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 483 insertions(+))
google-beta provider: Diff ( 4 files changed, 483 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 122 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_automatedBackupConfig

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 483 insertions(+))
google-beta provider: Diff ( 4 files changed, 483 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 122 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_automatedBackupConfig

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 483 insertions(+))
google-beta provider: Diff ( 4 files changed, 483 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 122 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_automatedBackupConfig

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 483 insertions(+))
google-beta provider: Diff ( 4 files changed, 483 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 122 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_automatedBackupConfig

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 388 insertions(+))
google-beta provider: Diff ( 4 files changed, 388 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 93 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 389 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 389 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 93 insertions(+))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 7
Skipped tests: 0
Affected tests: 10

Click here to see the affected service packages

• memorystore

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample
• TestAccMemorystoreInstance_switchoverAndDetachSecondary
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateInstanceEndpoints
• TestAccMemorystoreInstance_updateNodeType
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Debug log]
TestAccMemorystoreInstance_updateNodeType [Debug log]
TestAccMemorystoreInstance_updatePersistence [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Debug log]
TestAccMemorystoreInstance_updateShardCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[BBBmau]

great job on the tests, aside from the comments i left can you link me to the field reference? I was only able to find the redis documentation of memorystore

[NA2047]

great job on the tests, aside from the comments i left can you link me to the field reference? I was only able to find the redis documentation of memorystore

The API docs are still being worked on right now. but they the implmetation is the same as the ones I have provided :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 389 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 389 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 93 insertions(+))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 389 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 389 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 93 insertions(+))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

🟢 All tests passed!

View the build log

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NA2047]

Hey @BBBmau Could you take a look today or tomorrow please :)