Skip to content

Removed duplicate code in bigquery connection post_create #13521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 2, 2025

This is now handled by the changes in hashicorp/terraform-provider-google#22214

Part of hashicorp/terraform-provider-google#22214

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 15 deletions(-))
google-beta provider: Diff ( 1 file changed, 15 deletions(-))

@modular-magician modular-magician requested a review from wj-chen April 2, 2025 21:55
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 13
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • bigqueryconnection

🟢 All tests passed!

View the build log

@melinath
Copy link
Member Author

melinath commented Apr 2, 2025

@modular-magician reassign-reviewer

Copy link

github-actions bot commented Apr 2, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from slevenick April 2, 2025 22:05
@melinath melinath added this pull request to the merge queue Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants