Remove duplicate / unnecessary setting of fields in post_create code

[melinath]

What kind of contribution is this issue about?

Other (specify in details)

Details

GoogleCloudPlatform/magic-modules#12939 fixed an issue with resource generation where resources had to set fields in post_create custom code if they were needed for the follow-up Read request. This ticket covers follow-on work to evaluate usage of d.Set in post_create code and remove now-redundant usage.

• templates/terraform/post_create/accesspolicy.tmpl Removed accesscontextmanager.AccessPolicy post_create custom code GoogleCloudPlatform/magic-modules#13519
• templates/terraform/post_create/analytics_hub_subscription.go.tmpl Handle custom decoders as part of setting fields in post_create GoogleCloudPlatform/magic-modules#13520
• templates/terraform/post_create/bigquery_connection_id.go.tmpl Removed duplicate code in bigquery connection post_create GoogleCloudPlatform/magic-modules#13521
• templates/terraform/post_create/bigquery_dataset_access.go.tmpl N/A
• templates/terraform/post_create/chronicle_retrohunt_id.go.tmpl Switched async post-create setting of fields to check id format instead of 'identity' GoogleCloudPlatform/magic-modules#13693
• templates/terraform/post_create/chronicle_rule_id.go.tmpl Removed Chronicle Rule post_create GoogleCloudPlatform/magic-modules#13538
• templates/terraform/post_create/chronicle_watchlist_id.go.tmpl Removed Chronicle Watchlist post_create GoogleCloudPlatform/magic-modules#13539
• templates/terraform/post_create/cloudbuild_trigger_id.go.tmpl Removed duplicate code from Cloud Build Trigger post_create GoogleCloudPlatform/magic-modules#13540
• templates/terraform/post_create/colab_notebook_execution.go.tmpl
• templates/terraform/post_create/colab_runtime_template.go.tmpl
• templates/terraform/post_create/colab_schedule.go.tmpl
• templates/terraform/post_create/compute_firewall_policy.go.tmpl
• templates/terraform/post_create/firebasehosting_release.tmpl
• templates/terraform/post_create/firebasehosting_version_immediate_finalize.tmpl
• templates/terraform/post_create/gcip_tenant.go.tmpl
• templates/terraform/post_create/group.tmpl
• templates/terraform/post_create/iam_workforce_pool_provider.go.tmpl
• templates/terraform/post_create/iap_client.go.tmpl
• templates/terraform/post_create/index.go.tmpl
• templates/terraform/post_create/interconnect_attachment.go.tmpl
• templates/terraform/post_create/kms_secret_ciphertext.go.tmpl
• templates/terraform/post_create/labels.tmpl
• templates/terraform/post_create/lien.tmpl
• templates/terraform/post_create/org_security_policy.go.tmpl
• templates/terraform/post_create/regional_secret_version.go.tmpl
• templates/terraform/post_create/resource_compute_firewall_policy_with_rules.go.tmpl
• templates/terraform/post_create/resource_compute_network_firewall_policy_with_rules.go.tmpl
• templates/terraform/post_create/resource_compute_region_network_firewall_policy_with_rules.go.tmpl
• templates/terraform/post_create/secret_version.go.tmpl
• templates/terraform/post_create/sshkeyfingerprint_and_sleep.go.tmpl
• templates/terraform/post_create/storage_hmac_key.go.tmpl

We should also remove all usage of set_computed_name.tmpl if possible. This is used in a bunch of places:

• projects/magic-modules/mmv1/products/bigquerydatatransfer/Config.yaml Removed set_computed_name post_create for bigquerydatatransfer config GoogleCloudPlatform/magic-modules#13532
• projects/magic-modules/mmv1/products/cloudidentity/Group.yaml Removed cloud identity group set_computed_name post_create GoogleCloudPlatform/magic-modules#13627
• projects/magic-modules/mmv1/products/cloudidentity/GroupMembership.yaml Removed cloud identity group membership set_computed_name post_create GoogleCloudPlatform/magic-modules#13628
• projects/magic-modules/mmv1/products/dialogflow/EntityType.yaml Removed dialogflow entitytype set_computed_name post_create GoogleCloudPlatform/magic-modules#13629
• projects/magic-modules/mmv1/products/dialogflow/Fulfillment.yaml Removed dialogflow fulfillment set_computed_name post_create GoogleCloudPlatform/magic-modules#13630
• projects/magic-modules/mmv1/products/dialogflow/Intent.yaml Removed dialogflow intent set_computed_name post_create GoogleCloudPlatform/magic-modules#13631
• projects/magic-modules/mmv1/products/iap/Brand.yaml Removed iap brand set_computed_name post_create GoogleCloudPlatform/magic-modules#13632
• projects/magic-modules/mmv1/products/integrations/AuthConfig.yaml Removed integrations authconfig set_computed_name post_create GoogleCloudPlatform/magic-modules#13633
• projects/magic-modules/mmv1/products/logging/Metric.yaml Removed logging metric set_computed_name post_create GoogleCloudPlatform/magic-modules#13634
• projects/magic-modules/mmv1/products/monitoring/AlertPolicy.yaml Removed monitoring alertpolicy set_computed_name post_create GoogleCloudPlatform/magic-modules#13635
• projects/magic-modules/mmv1/products/monitoring/Group.yaml Removed monitoring group set_computed_name post_create GoogleCloudPlatform/magic-modules#13636
• projects/magic-modules/mmv1/products/monitoring/NotificationChannel.yaml Removed monitoring notificationchannel set_computed_name post_create GoogleCloudPlatform/magic-modules#13637
• projects/magic-modules/mmv1/products/monitoring/UptimeCheckConfig.yaml Removed monitoring uptimecheckconfig set_computed_name post_create GoogleCloudPlatform/magic-modules#13638
• projects/magic-modules/mmv1/products/osconfig/GuestPolicies.yaml Removed osconfig guestpolicies set_computed_name post_create GoogleCloudPlatform/magic-modules#13639
• projects/magic-modules/mmv1/products/osconfig/PatchDeployment.yaml Removed osconfig patchdeployment set_computed_name post_create GoogleCloudPlatform/magic-modules#13640
• projects/magic-modules/mmv1/products/securitycenter/NotificationConfig.yaml Removed securitycenter notificationconfig set_computed_name post_create GoogleCloudPlatform/magic-modules#13641
• projects/magic-modules/mmv1/products/securitycenter/ProjectNotificationConfig.yaml Removed securitycenter projectnotificationconfig set_computed_name post_create GoogleCloudPlatform/magic-modules#13642
• projects/magic-modules/mmv1/products/securitycenter/Source.yaml Removed securitycenter source set_computed_name post_create GoogleCloudPlatform/magic-modules#13643
• projects/magic-modules/mmv1/products/securitycenterv2/OrganizationNotificationConfig.yaml Removed securitycenterv2 organizationnotificationconfig set_computed_name post_create GoogleCloudPlatform/magic-modules#13644
• projects/magic-modules/mmv1/products/securitycenterv2/OrganizationSource.yaml Removed securitycenterv2 organizationsource set_computed_name post_create GoogleCloudPlatform/magic-modules#13645
• projects/magic-modules/mmv1/products/securitycenterv2/ProjectNotificationConfig.yaml Removed securitycenterv2 projectnotificationconfig set_computed_name post_create GoogleCloudPlatform/magic-modules#13646
• projects/magic-modules/mmv1/products/securityscanner/ScanConfig.yaml Removed securityscanner scanconfig set_computed_name post_create GoogleCloudPlatform/magic-modules#13647
• Delete templates/terraform/post_create/set_computed_name.tmpl

Other:

• Remove identity fields setting?

References

No response