Skip to content

Removed set_computed_name post_create for bigquerydatatransfer config #13532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 3, 2025

Part of hashicorp/terraform-provider-google#22214 - this should be duplicated code, because we already set name automatically if it's required.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 108 deletions(-))
google-beta provider: Diff ( 6 files changed, 108 deletions(-))

@modular-magician modular-magician requested a review from wj-chen April 3, 2025 18:32
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • bigquerydatatransfer
  • cloudidentity
  • dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudIdentityGroup

Get to know how VCR tests work

Copy link
Member

@wj-chen wj-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes to BQ resource.

@melinath
Copy link
Member Author

melinath commented Apr 3, 2025

@modular-magician reassign-reviewer

Copy link

github-actions bot commented Apr 3, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez April 3, 2025 19:12
@modular-magician
Copy link
Collaborator

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@ScottSuarez This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@ScottSuarez
Copy link
Contributor

@ScottSuarez This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

huh, this should of been classified as having been reviewed already?

@melinath
Copy link
Member Author

melinath commented Apr 10, 2025

@ScottSuarez This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

huh, this should of been classified as having been reviewed already?

it was approved but not merged - we remind on those as well to make sure they don't get lost (because they won't show up in someone's review queue)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 108 deletions(-))
google-beta provider: Diff ( 6 files changed, 108 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • bigquerydatatransfer
  • cloudidentity
  • dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudIdentityGroup

Get to know how VCR tests work

@ScottSuarez
Copy link
Contributor

@ScottSuarez This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

huh, this should of been classified as having been reviewed already?

it was approved but not merged - we remind on those as well to make sure they don't get lost (because they won't show up in someone's review queue)

oh! yeah that makes sense!

@modular-magician
Copy link
Collaborator

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

I'm going to split these into individual PRs so they're easier to review
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 deletions(-))
google-beta provider: Diff ( 1 file changed, 18 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigquerydatatransfer

🟢 All tests passed!

View the build log

@melinath melinath changed the title Removed set_computed_name post_create for products a-d Removed set_computed_name post_create for bigquerydatatransfer config Apr 11, 2025
@melinath melinath added this pull request to the merge queue Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants