-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Removed set_computed_name post_create for bigquerydatatransfer config #13532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed set_computed_name post_create for bigquerydatatransfer config #13532
Conversation
Tests analyticsTotal tests: 9 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving changes to BQ resource.
@modular-magician reassign-reviewer |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@ScottSuarez This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label |
huh, this should of been classified as having been reviewed already? |
it was approved but not merged - we remind on those as well to make sure they don't get lost (because they won't show up in someone's review queue) |
Tests analyticsTotal tests: 9 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
oh! yeah that makes sense! |
I'm going to split these into individual PRs so they're easier to review
Tests analyticsTotal tests: 1 Click here to see the affected service packages
🟢 All tests passed! View the build log |
88656dd
Part of hashicorp/terraform-provider-google#22214 - this should be duplicated code, because we already set
name
automatically if it's required.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.