Skip to content

Google Cloud Build logging options #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
giladsh1 opened this issue Aug 12, 2019 · 1 comment · Fixed by #4043
Closed

Google Cloud Build logging options #2637

giladsh1 opened this issue Aug 12, 2019 · 1 comment · Fixed by #4043
Labels
area/build build/gcb kind/feature-request priority/p1 High impact feature/bug.

Comments

@giladsh1
Copy link

It seems like Skaffold is hammering the
when running with google cloud build builder, I got the following error message -

FATA[0476] failed to build: build failed: building [eu.gcr.io/riscale/http]: getting build status: googleapi: Error 429: Quota exceeded for quota metric 'cloudbuild.googleapis.com/get_requests' and limit 'GetRequestsPerMinutePerProject' of service 'cloudbuild.googleapis.com' for consumer 'project_number:<project number>'., 
rateLimitExceeded

Expected behavior

implement a proper backoff when using google cloud build API.
Also, allow additional options for google cloud build logging such as -

options:
  logging: GCS_ONLY
  logStreamingOption: STREAM_ON

Actual behavior

the build crashes

Information

  • Skaffold version: v0.35.0
  • Operating system: MacOS
  • Contents of skaffold.yaml:
@balopat balopat added kind/bug Something isn't working priority/p1 High impact feature/bug. labels Aug 13, 2019
@balopat
Copy link
Contributor

balopat commented Aug 13, 2019

Thank you for opening this!

Regarding the rate limit backoff request, that is a dupe of ##1589, so I'll reopen #1589 to track that work.

I'll keep this issue as a feature request for GCB logging options.

@balopat balopat added kind/feature-request and removed kind/bug Something isn't working labels Aug 13, 2019
@balopat balopat changed the title google cloud build rate limit backoff Google Cloud Build logging options Aug 13, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 28, 2020
@dgageot
Support Google Cloud Build logging options
b318ed8 
Fixes GoogleContainerTools#2637

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot mentioned this issue Apr 28, 2020
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 29, 2020
@dgageot
Support Google Cloud Build logging options
161b1b3 
Fixes GoogleContainerTools#2637

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 29, 2020
@dgageot
Support Google Cloud Build logging options
1797539 
Fixes GoogleContainerTools#2637

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit that referenced this issue Apr 29, 2020
@dgageot
Support Google Cloud Build logging options (#4043)
a904077 
Fixes #2637

Signed-off-by: David Gageot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build build/gcb kind/feature-request priority/p1 High impact feature/bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Google Cloud Build logging options dgageot/skaffold
2 participants
@balopat @giladsh1