Skip to content

Support Google Cloud Build logging options #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2020
Merged

Support Google Cloud Build logging options #4043

merged 1 commit into from
Apr 29, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 28, 2020

Fixes #2637

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Apr 28, 2020 •
edited
Loading

Codecov Report

Merging #4043 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/build/gcb/spec.go 94.11% <100.00%> (+0.36%) ⬆️

briandealwis
briandealwis approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can provide the values to get enum and autocomplete support.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 28, 2020
@dgageot
Copy link
Contributor Author

dgageot commented Apr 28, 2020

Let's check what this does to the documentation before we merge

@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Apr 28, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@container-tools-bot
Copy link

Please visit http://34.94.104.146:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 29, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dgageot dgageot merged commit a904077 into GoogleContainerTools:master Apr 29, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Cloud Build logging options
4 participants
@dgageot @googlebot @container-tools-bot @briandealwis