Skip to content

Error message for outdated version of Skaffold directs to invalid download link #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sujit-kamireddy opened this issue Oct 30, 2019 · 0 comments · Fixed by #3201
Closed

Error message for outdated version of Skaffold directs to invalid download link #3142

sujit-kamireddy opened this issue Oct 30, 2019 · 0 comments · Fixed by #3201
Assignees
@dgageot
Labels
area/logging good first issue Good for newcomers help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/bug Something isn't working priority/p2 May take a couple of releases

Comments

@sujit-kamireddy
Copy link

Upon running
skaffold run --enable-rpc -v info --rpc-http-port 51328 --filename skaffold.yaml
time="2019-08-07T11:51:11-07:00" level=info msg="Skaffold &{Version:v0.27.0 ConfigVersion:skaffold/v1beta8 GitVersion: GitCommit:6e9c61df6336540325b927071d62947b261a77bf GitTreeState:clean BuildDate:2019-04-12T17:58:53Z GoVersion:go1.11.8 Compiler:gc Platform:darwin/amd64}"

Expected behavior

The error message should have a valid installation url.

Actual behavior

The skaffold download url in the error message (below) has a trailing \n that makes it invalid.
time="2019-08-07T11:51:11-07:00" level=warning msg="Your Skaffold version might be too old. Download the latest version (0.35.0) at https://storage.googleapis.com/skaffold/releases/latest/skaffold-darwin-amd64\n"

Information

  • Operating system: OSX
@balopat balopat added kind/bug Something isn't working good first issue Good for newcomers priority/p2 May take a couple of releases help wanted We would love to have this done, but don't have the bandwidth, need help from contributors area/logging labels Nov 1, 2019
@dgageot dgageot self-assigned this Nov 7, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Nov 7, 2019
@dgageot
Remove trailing \n from download url
4f35cc7 
Fixes GoogleContainerTools#3142
@dgageot dgageot mentioned this issue Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/logging good first issue Good for newcomers help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/bug Something isn't working priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove trailing \n from download url dgageot/skaffold
3 participants
@dgageot @balopat @sujit-kamireddy