Skip to content

Remove trailing \n from download url #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

Remove trailing \n from download url #3201

merged 1 commit into from
Nov 7, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 7, 2019

Fixes #3142

@codecov
Copy link

codecov bot commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #3201 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/runner.go 75% <0%> (ø) ⬆️
pkg/skaffold/util/tar.go 43.61% <0%> (-4.26%) ⬇️

@balopat balopat merged commit e4857fa into GoogleContainerTools:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message for outdated version of Skaffold directs to invalid download link
4 participants
@dgageot @briandealwis @balopat @googlebot