Skip to content

[Bug] Build artifacts sync.infer does not work #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvokka opened this issue Dec 13, 2019 · 2 comments · Fixed by #3439
Closed

[Bug] Build artifacts sync.infer does not work #3376

kvokka opened this issue Dec 13, 2019 · 2 comments · Fixed by #3439
Assignees
Labels
area/sync kind/bug Something isn't working needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.

Comments

@kvokka
Copy link

kvokka commented Dec 13, 2019

Expected behavior

Full description here

Actual behavior

With infer syntax i do not get the file sync, when with the same, using manual sync everything works.

for the testing purposes i used the file app/views/profile/index.html.haml (if it matters)

Information

  • Skaffold version: version 1.0.1
  • Operating system: MacOs 10.15.1
  • Contents of skaffold.yaml:
apiVersion: skaffold/v1
kind: Config
build:
  tagPolicy:
    gitCommit: {}
profiles:
  - name: rails_dev
    build:
      artifacts:
        - image: us.gcr.io/replay-gaming/rails
          docker:
            dockerfile: docker/development/Dockerfile
          context: rails
          sync:
            # but this commented syntax works
            # manual:
            #  - src: 'app/**/*'
            #   dest: '.'
            infer:
              - 'app/**/*'
    deploy:
      helm:
        releases:
          - name: rails
            chartPath: rails/charts/rails
            valuesFiles:
              - rails/charts/rails/values.development.yaml
            skipBuildDependencies: true
            values:
              image: us.gcr.io/replay-gaming/rails

@dgageot dgageot added area/sync kind/bug Something isn't working labels Dec 17, 2019
@balopat balopat changed the title [Bug] Build artifacts sync.manual.infer does not works [Bug] Build artifacts sync.infer does not work Dec 18, 2019
@balopat balopat added priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence. needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug labels Dec 18, 2019
@balopat
Copy link
Contributor

balopat commented Dec 18, 2019

Thanks for opening! Can you provide a Dockerfile as well please so that we can try to reproduce the behavior? Thank you!

@kvokka
Copy link
Author

kvokka commented Dec 18, 2019

Np, here it is:

FROM ruby:2.4.6-jessie

ENV REFRESHED_AT 2019-11-18

ENV APP_HOME /app
WORKDIR $APP_HOME

ENV LANG C.UTF-8

RUN curl -sL https://deb.nodesource.com/setup_10.x | bash -

# Install packages
RUN apt-get update && apt-get install -y --no-install-recommends \
  build-essential \
  git \
  ruby-dev \
  libgdbm-dev \
  libncurses5-dev \
  libffi-dev \
  libyaml-dev \
  libreadline-dev \
  sqlite3 \
  libsqlite3-dev \
  mysql-client \
  libmysqlclient-dev \
  libcurl4-openssl-dev \
  curl \
  imagemagick \
  libmagickwand-dev \
  geoip-bin \
  geoip-database \
  libgeoip-dev \
  nodejs

RUN gem install geoip-c

# Install gems
ADD Gemfile* $APP_HOME/
ADD package*.json $APP_HOME/
ADD docker/entrypoint $APP_HOME/docker/entrypoint
RUN bundle install --jobs="$(getconf _NPROCESSORS_ONLN)"
RUN npm install
RUN chmod 777 node_modules/webpack/bin/webpack.js

COPY build.json $APP_HOME
COPY .eslintrc.js $APP_HOME
COPY webpack.config.js $APP_HOME
COPY config.ru $APP_HOME
COPY Rakefile $APP_HOME/Rakefile
COPY bin $APP_HOME/bin
COPY vendor/assets $APP_HOME/vendor/assets
COPY db $APP_HOME/db
COPY public $APP_HOME/public
COPY script $APP_HOME/script
COPY config $APP_HOME/config
COPY lib $APP_HOME/lib
COPY app $APP_HOME/app

ENTRYPOINT [ "docker/entrypoint" ]

@dgageot dgageot self-assigned this Dec 24, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sync kind/bug Something isn't working needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants