Skip to content

Fix sync infer when COPY destination contains an env variable #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2020
Merged

Fix sync infer when COPY destination contains an env variable #3439

merged 2 commits into from
Jan 8, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 24, 2019

Fix #3376

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #3439 into master will increase coverage by 0.02%.
The diff coverage is 95.23%.

Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 87.76% <95.23%> (+0.06%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️
pkg/skaffold/util/tar.go 57.47% <0%> (+4.59%) ⬆️

@nkubala nkubala merged commit d9b8591 into GoogleContainerTools:master Jan 8, 2020
@dgageot dgageot mentioned this pull request Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Build artifacts sync.infer does not work
4 participants
@dgageot @briandealwis @nkubala @googlebot