Skip to content

fix(docs) updated references for imageName to be image #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2019
Merged

fix(docs) updated references for imageName to be image #1468

merged 1 commit into from
Jan 15, 2019

Conversation

garethjevans
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019 •
edited
Loading

Codecov Report

Merging #1468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1468   +/-   ##
=======================================
  Coverage   44.43%   44.43%           
=======================================
  Files         112      112           
  Lines        4641     4641           
=======================================
  Hits         2062     2062           
  Misses       2372     2372           
  Partials      207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3eb78f...fb3e0c5. Read the comment docs.

@dgageot
Copy link
Contributor

dgageot commented Jan 15, 2019

Thanks a lot @garethjevans
Looks like there's more broken bits. I'll try to fix them

@dgageot dgageot merged commit 2f99903 into GoogleContainerTools:master Jan 15, 2019
garethjevans added a commit to garethjevans/skaffold that referenced this pull request Jan 16, 2019
@garethjevans
Revert "Merge pull request GoogleContainerTools#1468 from garethjevan…
37efa6b 
…s/docs"

This reverts commit 2f99903, reversing
changes made to e3eb78f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garethjevans @codecov-io @dgageot