Skip to content

fix(docs) updated references for imageName to be image #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/content/en/docs/how-tos/builders/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Docker image `gcr.io/k8s-skaffold/example` with the local Docker daemon:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
# Use local Docker daemon to build artifacts
local:
skipPush: false
Expand All @@ -62,7 +62,7 @@ build:
# The build section above is equal to
# build:
# artifacts:
# - imageName: gcr.io/k8s-skaffold/example
# - image: gcr.io/k8s-skaffold/example
# local: {}
```

Expand Down Expand Up @@ -96,7 +96,7 @@ Docker image `gcr.io/k8s-skaffold/example` with Google Cloud Build:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
# Use Google Cloud Build to build artifacts
googleCloudBuild:
projectId: YOUR-GCP-PROJECT
Expand Down Expand Up @@ -128,7 +128,7 @@ Docker image `gcr.io/k8s-skaffold/example` with Kaniko:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
# Use Kaniko to build artifacts
kaniko:
buildContext: gs://YOUR-BUCKET/SOURCE-CODE.tar.gz
Expand All @@ -148,7 +148,7 @@ Skaffold can help build artifacts using Bazel; after Bazel finishes building
container images, they will be loaded into the local Docker daemon. To use
Bazel, add `workspace` and `bazel` fields to each artifact you specify in the
`artifacts` part of the `build` section, and use the build type `local`.
`workspace` should be a path containing the bazel files
`context` should be a path containing the bazel files
(`WORKSPACE` and `BUILD`); The `bazel` field should have a `target`
specification, which Skaffold will use to load the image to the Docker daemon.

Expand All @@ -158,8 +158,8 @@ Docker image `gcr.io/k8s-skaffold/example` with Bazel:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
workspace: .
- image: gcr.io/k8s-skaffold/example
context: .
bazel:
target: //:example.tar
local: {}
Expand Down
4 changes: 2 additions & 2 deletions docs/content/en/docs/how-tos/profiles/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ The following example, showcases a `skaffold.yaml` with one profile, `gcb`,
for building with Google Cloud Build:

```yaml
apiVersion: skaffold/v1alpha2
apiVersion: skaffold/v1beta2
kind: Config
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/skaffold-example
- image: gcr.io/k8s-skaffold/skaffold-example
deploy:
kubectl:
manifests:
Expand Down
10 changes: 5 additions & 5 deletions docs/content/en/docs/how-tos/taggers/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ specified explicitly:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
tagPolicy:
gitCommit: {}
local: {}
Expand All @@ -58,7 +58,7 @@ Docker image `gcr.io/k8s-skaffold/example` with the `sha256` tag policy:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
tagPolicy:
sha256: {}
local: {}
Expand Down Expand Up @@ -90,7 +90,7 @@ the <code>artifacts</code> part of the <code>build</code> section.
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
tagPolicy:
envTemplate:
template: "{{.IMAGE_NAME}}:{{.FOO}}"
Expand Down Expand Up @@ -118,7 +118,7 @@ tag policy:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
tagPolicy:
dateTime:
format: "2006-01-02_15-04-05.999_MST"
Expand All @@ -127,7 +127,7 @@ build:
# The build section above is equal to
# build:
# artifacts:
# - imageName: gcr.io/k8s-skaffold/example
# - image: gcr.io/k8s-skaffold/example
# tagPolicy:
# dateTime: {}
# local: {}
Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/how-tos/templating/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ For example:
```yaml
build:
artifacts:
- imageName: gcr.io/k8s-skaffold/example
- image: gcr.io/k8s-skaffold/example
tagPolicy:
envTemplate:
template: "{{.IMAGE_NAME}}:{{.FOO}}"
Expand Down