Skip to content

Warn about unused configs #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 14, 2019

Fixes #2972

Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #3046 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 57.45% <100%> (ø) ⬆️

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@balopat balopat merged commit 6afc2b1 into GoogleContainerTools:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold init erroneously thinks there are unused builder configs
4 participants