Skip to content

Warn about unused configs #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Warn about unused configs #3046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76ba80c
Fix typo
dgageot Oct 14, 2019
a641176
Warn about unused configs
dgageot Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/skaffold/initializer/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func DoInit(ctx context.Context, out io.Writer, c Config) error {
return err
}

// Remote tags from image names
// Remove tags from image names
var images []string
for _, image := range k.GetImages() {
parsed, err := docker.ParseReference(image)
Expand Down Expand Up @@ -359,8 +359,8 @@ func resolveBuilderImages(builderConfigs []InitBuilder, images []string) []build
}
images = util.RemoveFromSlice(images, image)
}
if len(builderConfigs) > 0 {
logrus.Warnf("unused builder configs found in repository: %v", builderConfigs)
if len(choices) > 0 {
logrus.Warnf("unused builder configs found in repository: %v", choices)
}
return pairs
}
Expand Down