Skip to content

Add pod checks #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Add pod checks #3952

merged 4 commits into from
Apr 21, 2020

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Apr 14, 2020

Should merge after #3938
Fixes: #3915
Relates to: #3739, #3813

Description
In this PR, i am trying to move parts of #3917

User facing changes (remove if N/A)
No user facing changes for skaffold users.

Follow-up Work (remove if N/A)

  • Hook up pod health checker.
  • Make status check interruptible.

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #3952 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/debug/transform_python.go 84.33% <0.00%> (-0.37%) ⬇️
pkg/skaffold/debug/transform_go.go 85.86% <0.00%> (-0.31%) ⬇️
pkg/skaffold/debug/transform_nodejs.go 77.67% <0.00%> (-0.20%) ⬇️
pkg/skaffold/debug/transform_jvm.go 94.68% <0.00%> (-0.06%) ⬇️
pkg/skaffold/debug/transform.go 89.37% <0.00%> (ø)
pkg/skaffold/schema/versions.go 75.00% <0.00%> (ø)
pkg/skaffold/deploy/kubectl/visitor.go 93.54% <0.00%> (ø)
pkg/skaffold/errors/errors.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/v2beta1/config.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/v2beta1/upgrade.go 77.77% <0.00%> (ø)
... and 1 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hook up pod Container statuses with Skaffold status check phase
3 participants