Add pod logs for terminated container in status check. #4303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
briandealwis,
dgageot,
nkubala and
tstromberg
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4303 +/- ##
==========================================
- Coverage 71.85% 71.74% -0.11%
==========================================
Files 324 324
Lines 12449 12468 +19
==========================================
Hits 8945 8945
- Misses 2935 2954 +19
Partials 569 569
Continue to review full report at Codecov.
|
briandealwis
approved these changes
Jun 11, 2020
pkg/diag/validator/pod.go
Outdated
Comment on lines
251
to
254
| lines := strings.Split(string(logs), "\n") | ||
| for i, s := range lines { | ||
| lines[i] = fmt.Sprintf("[%s %s]%s", po.Name, c, s) | ||
| } |
There was a problem hiding this comment.
I think this output formatting should be moved into Deployment.ReportSinceLastUpdated(). Just gather it here.
There was a problem hiding this comment.
the only issue, we dont' have the container name in the pod status. hence i added it here.
Also, if any other tool uses the diag library, they could rely on logs as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #3952
In this Pr, add logs for containers which are not healthy. These logs are now on the command line.
TODO: @balopat should these also be part of the Event API ?
On master previously, without pod logs for terminated containers,
skaffold devthe pods get cleaned up. There is no way for users to access these logs afterskaffold devloop.On this branch,