[buildpacks] Initial support for project.toml #4258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
briandealwis,
nkubala,
tejal29 and
tstromberg
as code owners
Codecov Report
|
Comment on lines
90
to
92
| buildpacks := artifact.Buildpacks | ||
| for _, buildpack := range projectDescriptor.Build.Buildpacks { | ||
| // TODO(dgageot): Support version and URI. | ||
| buildpacks = append(buildpacks, buildpack.ID) | ||
| } |
There was a problem hiding this comment.
So I think the buildpacks specified in the skaffold.yaml should override those in the buildpack.toml. We may have duplicates here too. (And good point about versions too.)
(We should have a test for this resolution process.)
briandealwis
approved these changes
May 27, 2020
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
briandealwis
approved these changes
May 27, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skaffold initrecognizes a project.toml