-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: support artifactOverrides
schema functionality from v2beta* in v3alpha* via setValue*
#7707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
973e579
to
9191b71
Compare
826724e
to
b2ee1e2
Compare
Codecov Report
@@ Coverage Diff @@
## main #7707 +/- ##
==========================================
- Coverage 70.48% 66.55% -3.94%
==========================================
Files 515 589 +74
Lines 23150 28300 +5150
==========================================
+ Hits 16317 18834 +2517
- Misses 5776 8083 +2307
- Partials 1057 1383 +326
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
b2ee1e2
to
f17cde8
Compare
f17cde8
to
5d34fbe
Compare
Actually, we are getting rid of |
Talked offline, this issue supports the v3 schema removal of |
setValue*
setValue*
artifactOverrides
schema functionality from v2beta* in v3alpha* via setValue*
|
@iosifnicolae2 can you paste a redacted |
@aaron-prindle I've added a GitHub repo and how to reproduce the issue in #8008 Thank you! |
Fixes #7668
Fixes #6952
Uses the suggestion recommended by @briandealwis in the issue above to migrate
artifactOverrides
configuration to similarsetValues
andsetValueTemplates
configurations.Prior to this PR, users using
artifactOverrides
with v2beta* would have their projects broken asartifactOverrides
config was dropped going v2beta* -> v3alpha1. This PR parses the v2beta*artifactsOverrides
and converts it to appropriatesetValues
andsetValueTemplates
config which v3alpha1 supports. There still might be some possible errors with the currently implementation related to the error mentioned in the issue:I will make a separate issue tracking the above case which still needs to be accounted for but this way the majority of
artifactOverrides
users will not be broken in the migration and won't have to manually update theirskaffold.yaml
EDIT: Related to above ^^^^ statement. Talked offline w/ Brian, the error referenced above would be an ongoing error and NOT a regression. He is happy with the approach here and the above issue is not high priority (no regression)
NOTE: The changes to examples/templated-fields in this PR were lost when rebasing the v2 branch onto main from #6952 and that is why they are added back here