-
-
Notifications
You must be signed in to change notification settings - Fork 279
Remove NeogitCommitMessage filetype #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NeogitCommitMessage filetype #415
Conversation
syntax/NeogitStatus.vim
Outdated
syn match gitcommit /.*/ contained | ||
syn match NeogitBranch /\S\+/ contained nextgroup=gitcommit | ||
syn match NeogitRemote /\S\+/ contained nextgroup=gitcommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entirely sure but those probably can just be removed. Nvim comes with gitcommit syntax as well as there is treesitter parser for gitconmit now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try removing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, these can be removed altogether. Incorrect. See below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An update on this: These should not be removed, and should be left unchanged. I was mistaken before: they have nothing to do with the NeogitGitCommit popup. These three lines are just for syntax highlighting on the status buffer of the branch name/remote name.
This change would prevent |
if api.nvim_buf_get_option(o.buf, "filetype"):find("Neogit") then
return
end This could/should also check for |
Yea. I've been running with this patch for a week or two now without issue, and without addressing the above autocmd. |
a3c4092
to
c4068a2
Compare
Sorry guys, I'll promise that I'll fix it |
Close #405