Upstreaming 5/n - Cleanup syntax files

[CKolkey]

This is just a general cleanup of the syntax files. A lot of the sign definitions have been extracted to a lua file, as well as highlight definitions. Makes it easier to do dynamic highlights/signs and prevent issues for users who have syntax disabled.

[CKolkey]

@ten3roberts - The failing spec is just because of the same issues that are corrected in the base branch. I don't have a button to re-run CI here though.

Looks like it ran.

[ten3roberts]

Is this related to the sections like HEAD: {...} and headlines like Recent commits having a different color?

[CKolkey]

Yea, but that's all unchanged. All this PR is doing is removing the hi link and sign define calls, since those are now in neogit/lib/hl and neogit/lib/signs... and some formatting changes.

The advantage of that is:

1. Signs are still defined for users who have syntax off. (resolves: Error message when opening #465)
2. Highlights groups are all defined in one place, allowing for a common pallette to be used.

• hl.lua
• signs.lua

[ten3roberts]

So if I am understanding this all right this just removes now unnused syntax files in favor of the already merged nvim_sign_define nvim_set_hl etc.

How related are the upstreaming changes to

#415?
and
#405?

[CKolkey]

You are 100% right, and not really related at all.

The next PR in the stack addresses filetypes (the linked issues), and I came to the conclusion we can have the best of both worlds: custom filetypes for neogit buffers, and treesitter parsers turned on (if available). I think its very handy to be able to define behaviour that doesn't leak out, but, like I said, thats up next :)

[ten3roberts]

Agreed, it is advantageous to make use of treesitter rather than our own hand rolled regexes