AppGateway #118
AppGateway #118
Conversation
Includes AppGateway ps1 Includes template json
|
|
||
| [Parameter(Mandatory=$true)] | ||
| [string] | ||
| $frontendPorts |
There was a problem hiding this comment.
There needs to be comma separation between parameters. This is causing issues while running the script.
|
It would be very helpful if you give some basic steps to test your script including the script command that you are using. Also, when you ask for IP pools, documentation would again be needed to see what format is the input expected in. I would start with writing a basic step by step process to test your script. Including but not limited to what is expected as input to specific parameters that are not very common as opposed to location names or resource group names where it is fairly straightforward to guess the inputs. |
|
|
||
| [Parameter(Mandatory=$true)] | ||
| [string] | ||
| $httpListeners |
|
|
||
| [Parameter(Mandatory=$true)] | ||
| [string] | ||
| $requestRoutingRules |
|
Did you try running your script at all? The non-linked issue has no time tracking so I'm curious how much time was spent actually testing this. There's also no logic for logging into Azure in the script itself which is something I did wrong the previous sprint. The point of the automation stuff seems to be scripts that can just run on any given machine with minimal setup. This could just be on me and not an actually expected thing but I personally don't know what a lot of the parameters the script is asking for off the top of my head and wouldn't be able to test those given no instructions or default testing values. |
Includes AppGateway ps1
Includes template json