Task7 azurestoragescript

[Dylan-Riley]

Resolves #7

[Dylan-Riley]

Required:

* Powershell

* Powershell module Az version 0.7 or later:  `Get-InstalledModule -Name "Az"` to check
  
  * See [Introducing the Azure Az PowerShell Module](https://docs.microsoft.com/en-us/powershell/azure/install-Az-ps?view=azps-5.3.0)

Script can be found in [REPO]\Automation\create_Azure_StorageAccount.ps1

Open up a PowerShell window
Sign in to Azure through PowerShell: Connect-AzAccount Follow instructions on screen
In the Powershell window type "&" space and then drag the script file, this should auto fill in the command & "[PATH TO FILE]\create_Azure_StorageAccount.ps1"
Run the command
You will see basic Write-Host output as script runs
Resource Group and Storage Account names are declared as variables in script
Script will check if resource group exists, then create it if it doesn't
Script will check if a Storage Account with that name exists

* If it doesn't exist, script will create a storage account in the above resource group in US West 2 configured for Read-Access geo-redundant storage, using general purpose V2 storage.

* If it does exist print a message saying so

Output of script also saved in a text file create_Azure_StorageAccountlog.log
I'm honestly not sure how .gitignore files are shared amongst pulls, recommend making sure the .log file is ignored.
To run script again and make sure it works open Azure Console and delete either nsc-ad440-winter2021-Th-StorageRG Resource Group or nscad440thsa Storage Account

[1jc]

Looks good reviewed by 1jc Team2. Ready for Pull and Merge.

[1jc]

1jc checked individual coding for task several times 1jc

[toddysm]

@theanticrumpet Hard coding the name of the resource group is not a group practice. This makes the script inflexible - i.e. once you use it you cannot reuse it again if the resource groups. It is better if you make those at least input parameters for the script.

CC:// @1jc

[Dylan-Riley]

I was a little hesitant to do what you suggested in slack where I take multiple inputs and combine them into the RG name since that would just lead to a bunch of similarly named but different RGs. Would prompting for the RG name be sufficient?

[toddysm]

@theanticrumpet Same comment as above

CC:// @1jc

[toddysm]

@theanticrumpet Same comment as above

CC:// @1jc

[toddysm]

@theanticrumpet I do not see a logic to sign into the Azure account. This line will fail if I try to run the script. There should be logic to sign into Azure and select the right tenant and subscription.

CC:// @1jc

[toddysm]

@theanticrumpet I would prefer that you use ARM template to create the storage account instead doing this manually in the script. ARM templates provide additional benefits like for example checking if the resource exist, can be run asynchronously etc.

I would suggest you investigate that option.

CC:// @1jc

[Dylan-Riley]

Definitely looks like I've got more reading to do on general Azure + Powershell scripting instead of specific functions

[toddysm]

This line will block the script for executing without manual interaction. Not a good practice for automation scripts. CI/CD and other automation systems will not be able to use your script.

[Dylan-Riley]

Wait, do I want to take user input or not? Wouldn't the previous examples of requiring user input (EG: for resource group) also halt? Should I just make the whole thing take command line arguments as well?

[OyunominJuno]

I might be wrong but for those dynamic variables you can use the Key Vault and share them within your team.