Skip to content

Add new Misk Kotlin Server Generator #20883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewwilsonnew opened this issue Mar 14, 2025 · 1 comment · Fixed by #20885
Closed

Add new Misk Kotlin Server Generator #20883

andrewwilsonnew opened this issue Mar 14, 2025 · 1 comment · Fixed by #20885
Labels
Enhancement: Feature

Comments

@andrewwilsonnew
Copy link
Contributor

andrewwilsonnew commented Mar 14, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe.

Looking to build and support a new generator for Misk

Describe the solution you'd like

A new generator that builds:

  • Proto classes for the model which are compiled with Wire
  • Generated kotlin classes for the api

Describe alternatives you've considered

n/a

Additional context

Misk is an Apache2.0 Open Source Web Container written in Kotlin
@andrewwilsonnew
Copy link
Contributor Author

andrewwilsonnew commented Mar 14, 2025 •
edited
Loading

I don't seem to be able to assign or add labels - guessing admins have to do this... do I need write access eventually?

I've made a Draft PR #20885

wing328 added a commit that referenced this issue Mar 25, 2025
@andrewwilsonnew @guiarn @wing328
#20883 - Add new Misk Kotlin OpenAPI Generator (#20885)
d81b5a3 
* first pass

* Fix extra new line

* adding generator file

* Run new.sh script

* Fix template directory and ignore failing tests

* fixing up content type

* adding controller impl

* cleanup interface

* typo

* removing bodytype

* adding protos

* fixing 2

* Fix headerParamsSimple

* removing protos etc.

* fixing imports

* removing commented code

* fixing imports

* fixing return

* fixing file

* adding comment

* remove adminapi

* move to jakarta

* reverting break

* fixing httpMethods

* pushing mediaTypes

* Adds gradle mustache templates

* Setup simple build.gradle.kts

* Adds basic model.mustache for model generation

* fixing summary

* fixing summary 2

* Removes unnecesssary line

* fixing return type

* fixing override

* fixing httpcall

* Delete proto folder creation

* fixing return type

* fixing void return type

* fixing space

* removing reactive

* removing imports

* Fixing spacing

* Fixing tabbing

* fixing headers

* add comment

* Adds unit tests

* cleanup

* Correct getHelp() description

* cleanup 2

* removiing pathParams files

* fixup

* fixup 3

* removing more files

* Adds GitHub Workflow generation

* removing form params as not required

* Adds tests for OptionsProvider

* Renamed file to match

* remove whitespace

* remove whitespace

* adding documentation

* adding documentation

* removing swagger annotations

* adding tests

* Adds Guice Module

* Grab OpenAPI title to generate module name

* Revert "Grab OpenAPI title to generate module name"

This reverts commit 9c9b935f5dbee6e0974ebf66b4f611f107df70c2.

* Update sample

* Removes moduleFileName additional property

* adding tests

* adding tests 2

* adding tests 3

* adding tests 4

* added media types

* re-adding tests

* fixing camelcase

* fixing mediatypes

* default mediatype

* adding validation

* adding validation

* removing swagger

* adding gradle dependency

* adding gradle dependency

* fixing types

* fixing return types

* fixing tests

* final fixes

* tweaks

* fixing file etc.

* Update samples/ folder

* fixing jakarta

* fixing jakarta 2

* fixing impl

* Fix unit tests

* fixing jakarta

* fixing jakarta 2

* final final final changes

* Fix initialization of BigDecimal for default values

* update samples, docs

* fixing RequestHeader

* fixing RequestHeader 2

* fixing RequestHeader 2

* add validateSpec=false

* fix pom version

---------

Co-authored-by: Guido Arnau <[email protected]>
Co-authored-by: William Cheng <[email protected]>
@wing328 wing328 mentioned this issue Mar 25, 2025
Merged
5 tasks
@wing328 wing328 closed this as completed Mar 25, 2025
@andrewwilsonnew andrewwilsonnew mentioned this issue Mar 26, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new Misk Kotlin OpenAPI Generator andrewwilsonnew/openapi-generator
2 participants
@wing328 @andrewwilsonnew