Skip to content

Improving Misk Kotlin Server Generator #20973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 4, 2025

Conversation

andrewwilsonnew
Copy link
Contributor

@andrewwilsonnew andrewwilsonnew commented Mar 26, 2025

Improving #20883

  • Adding: application/zip, img/tiff, multipart/form-data to MediaTypes
  • Renaming Controller -> Action
  • Adding @guiarn to authors

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@andrewwilsonnew
Copy link
Contributor Author

andrewwilsonnew commented Mar 26, 2025

@wing328 just a couple of tweaks, waiting for a Misk build and then will be ready

@andrewwilsonnew andrewwilsonnew changed the title Improving Misk Kotlin Server Generator Media Types Improving Misk Kotlin Server Generator Mar 26, 2025
@andrewwilsonnew andrewwilsonnew marked this pull request as draft March 26, 2025 12:52
@andrewwilsonnew andrewwilsonnew marked this pull request as ready for review April 3, 2025 11:14
@andrewwilsonnew
Copy link
Contributor Author

@wing328 ready for review

@andrewwilsonnew
Copy link
Contributor Author

andrewwilsonnew commented Apr 4, 2025

@wing328 can we get this into the patch release - it has a couple of tweaks that would be useful.

@wing328 wing328 added this to the 7.13.0 milestone Apr 4, 2025
@wing328 wing328 merged commit 9bac318 into OpenAPITools:master Apr 4, 2025
35 checks passed
@wing328
Copy link
Member

wing328 commented Apr 4, 2025

merged. thanks for the PR

have a nice weekend

@andrewwilsonnew andrewwilsonnew deleted the cashapp/misk3 branch April 4, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants