Skip to content

#2195 add enum value getter for spring generator #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bilak
Copy link
Contributor

@bilak bilak commented Feb 20, 2019

fixes #2195

@bilak bilak force-pushed the bugfix/2195_fix-enum-value-getter-for-spring-generator branch from 277455a to 0eb9fdf Compare February 20, 2019 16:57
@wing328
Copy link
Member

wing328 commented Mar 7, 2019

@bilak thanks for the PR but it seems like it removes a lot of files. Is that expected?

@bilak
Copy link
Contributor Author

bilak commented Mar 7, 2019

@wing328 actually not, I just wanted to follow the contribution guide and this happened. If you can guide me through the process I can fix it.

@wing328
Copy link
Member

wing328 commented Mar 7, 2019

@bilak thanks for the explanation. Given that there are merge conflicts, do you mind filing a new one based on the latest master and do not update the samples? I'll update the sample later as part of the test. What do you think?

@bilak
Copy link
Contributor Author

bilak commented Mar 7, 2019

@wing328 definitelly can do that, just have a question. My intention was to modify this files enumClass.mustache and enumOuterClass.mustache. After usage in my local project I realised that it would be very helpful if the signature of method fromValue changes from fromValue(String value) to fromValue({{{dataType}}} value) but this is not backward compatible. This is helpful for jackson library at it knows how to create the object. What do you think about that? Do I have to change the signature or would it be ok to add another method with signature as I described?

Thanks

@wing328
Copy link
Member

wing328 commented Mar 7, 2019

After usage in my local project I realised that it would be very helpful if the signature of method fromValue changes from fromValue(String value) to fromValue({{{dataType}}} value) but this is not backward compatible. This is helpful for jackson library at it knows how to create the object. What do you think about that?

It's ok to have breaking changes for the upcoming 4.0.0 release but I would recommend creating a separate PR just for that as smaller PRs are easier to merge. In other words, a new PR based on latest master for this PR and another PR for fromValue.

@bilak
Copy link
Contributor Author

bilak commented Mar 10, 2019

closing in favour of #2346 and #2347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA-Spring] Enum without value getter
2 participants