[JAVA] Use specified data type in enum's fromValue instead of string #2347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilak
changed the title
|
@bilak please update the samples so that the CIs can test the change. Let me know if you need help on that. cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) |
bilak
force-pushed
the
feature/enum-fromvalue-with-datatype-instead-of-string
branch
from
3a47407 to
d718069
Compare
|
CircleCI reports the following errors: Please take a look when you've time. |
|
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) as the fix impacts Java generators (including Spring) |
|
I was looking at it and it seems to be ok. 👍 |
|
@bilak 👍 I'll merge after the shippable tests pass |
|
👍Great feature! |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Apr 1, 2019
* master: (48 commits) [Typescript AngularJS] fix Extra package prefix in api parameters operations (OpenAPITools#2522) OpenAPITools#1023 - [Scala] Use status family during response processing (OpenAPITools#1024) Generate setters for readonly properties in server code (OpenAPITools#1582) [JS] fix NPE for null string and improve Travis config file (OpenAPITools#2553) [elm] Update ISO 8601 library (fixes missing time zone designator) (OpenAPITools#2545) [csharp] update sample after OpenAPITools#2528 (OpenAPITools#2550) [JavaScript] fix index.js, ApiClient.js and test files generated to incorrect location (OpenAPITools#2511) Aspnetcore nullable support (OpenAPITools#2529) Csharp nullable support (OpenAPITools#2528) [C++] [Qt5] Add enum support for client and server (OpenAPITools#2339) Fixed typo in migration-from-swagger-codegen.md (OpenAPITools#2548) [TypeScript Client] fix install Aurelia + fix use deprecated function (OpenAPITools#2514) [KOTLIN] fix var name not correctly sanitized (OpenAPITools#2537) Update swagger-parser to '2.0.11-OpenAPITools.org-1' (OpenAPITools#2262) Add @karismann to Java and Kotlin technical committee (OpenAPITools#2542) Add GoDaddy to the list of companies using OpenAPI Generator (OpenAPITools#2541) [Kotlin SpringBoot Server] alternative: fix optional parameter not correctly declared in service (OpenAPITools#2539) improve indentation, update dependencies (OpenAPITools#2521) update kotlin spring samples [JAVA] Use specified data type in enum's fromValue instead of string (OpenAPITools#2347) ...
dkocher
added a commit
to iterate-ch/cyberduck
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with enums, specifically on web layer, it's better to create enum with target data type instead of string.