[dart-dio] Various fixes #5027
Merged
[dart-dio] Various fixes #5027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should eliminate potential issue with variables like `$ref`.
…with op params. See https://gist.githubusercontent.com/daohoangson/6431f46beb4c2d0d163f3a4791f518e8/raw/1bec0b47b1a00d1655689db1c2f6a399d10a5899/Kubernetes.json, there are a few with `{path}` param.
josh-burton
approved these changes
Jan 20, 2020
|
Looks good to me. Have run this on one of my specs and it's all looking good. |
|
@daohoangson thanks for the PR. @athornz thanks for reviewing. Do we need to wait for google/built_value.dart#804 to be merged by Google first before merging this PR? |
No, it's not required. |
jimschubert
added a commit
that referenced
this pull request
Jan 26, 2020
* 5.0.x: (92 commits) [Rust Server] Handle array of objects inside an object correctly (#5044) [Rust Server] Sanitise enum values (#5042) [Rust Server] Add support for primitive arrays (#5041) [elm] Fix duplicate coder names (#5100) [elm] enum items and parameters (#5051) [elm] Fix decoding empty operation responses (#5055) resolve merge conflicts in VERSION files undo restoring ElmClientCodegenTest.java fix merge conflicts [dart-dio] Various fixes (#5027) Add java code comments based on explanation from Jim Schubert (#5048) Execute ./bin/openapi3/go-experimental-petstore.sh script (#5049) [docs] Sorted doc outputs and clean up duplicated CliOptions (#5046) Add docs/installation.md and docsite index to version update script (#5037) [gradle] consistent use of maven url in gradle files (#5045) Use HTTPS Maven URL in Kotlin meta generator (#5043) [Python] fix numeric enum in python flask, aiohttp (#5019) add multipleOf to various codegen classes (#5021) Add a link to a youtube video on Pulp and OpenAPI Generator (#5038) [scripts] Remove misspelled OPENAPI_GENERATOR_DOWLOAD_CACHE_DIR (#5035) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few different fixes:
dateLibrary=timemachinepackage:http/io_client.dart$ref._pathinstead ofpathto avoid potential conflict with op params.These fixes are required when I try to generate for Kubernetes API (example json here).
Please note that this PR needs another PR to work properly (google/built_value.dart#804).
CC @ircecho @swipesight @jaumard @nickmeinhold @athornz @amondnet
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.