Skip to content

Fix unescaped string usage while generating ValueSourceClass #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2020

Conversation

daohoangson
Copy link
Contributor

No description provided.

@daohoangson
Copy link
Contributor Author

This should fix #784.

@davidmorgan
Copy link
Collaborator

Thanks. I'd like to make sure this works end to end including serialization; would you mind adding a test to the end_to_end_test package please? That means adding such a field to a value in end_to_end_test/lib/values.dart and updating the corresponding serialization test . The presubmit script tool/presubmit will check that everything builds okay with no analyzer errors.

Or, I can take a look if you like :)

Fair warning, it usually takes me ~weeks to get around to releasing built_value unless there is something urgent.

@daohoangson
Copy link
Contributor Author

Thanks. I'd like to make sure this works end to end including serialization; would you mind adding a test to the end_to_end_test package please? That means adding such a field to a value in end_to_end_test/lib/values.dart and updating the corresponding serialization test . The presubmit script tool/presubmit will check that everything builds okay with no analyzer errors.

I will attempt to do this myself. Thanks for the pointer.

Fair warning, it usually takes me ~weeks to get around to releasing built_value unless there is something urgent.

That is understood. Thank you.

@daohoangson
Copy link
Contributor Author

I have updated the PR with tests. Please take another look when you find the time, thank you @davidmorgan.

@davidmorgan
Copy link
Collaborator

Looks good, thanks! Could you please add a note to CHANGELOG.md? Don't worry too much about the details, I'll fix if needed when I next edit the file. Also feel free to add yourself to AUTHORS if you like.

@daohoangson
Copy link
Contributor Author

I have pushed a new commit to address your comment. Thanks @davidmorgan 👍

@davidmorgan
Copy link
Collaborator

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants