Skip to content

[csharp-netcore] [HttpClient] Refactored Models #8465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

[csharp-netcore] [HttpClient] Refactored Models #8465

wants to merge 23 commits into from

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Jan 18, 2021

One typo fixed in RestSharp library.

Refactored model constructor to use null reference types. A model's ToJson method now takes an optional JsonSerializerSettings object which defaults to the static object in ClientUtils when not set. Removed a model's GetHashCode override as this should probably be specifically set by end users.

PR checklist

  • Read the contribution guidelines.

  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.

  • Run the following to build the project and update samples:

    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh 
    

    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.

  • File the PR against the correct branch: master, 5.1.x, 6.0.x

  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

<a name="dependencies"></a>
## Dependencies

- [RestSharp](https://www.nuget.org/packages/RestSharp) - 106.11.4 or later
Copy link
Member

@wing328 wing328 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devhl-labs Don't think we need RestSharp as the dependency if using httpclient as the library option.

@devhl-labs
Copy link
Contributor Author

Removed that RestSharp reference and addressed the issues from @Blackclaws.

@wing328
Copy link
Member

wing328 commented Mar 4, 2021

@devhl-labs can you please try the latest master? We've added some tests, fixed a few minor issues and looks like the httpclient option is ready for some more tests.

Can you please give it a try to see if it meets your requirement?

@devhl-labs
Copy link
Contributor Author

devhl-labs commented Mar 18, 2021

I'm confused, I only see ApiClient.mustache in the HttpClient folder. Did you intend for me to add my templates to master and do a new pr to master?

@devhl-labs
Copy link
Contributor Author

I did a new pr to master.

#9073

@devhl-labs
Copy link
Contributor Author

I will revisit this branch once #9235 is merged.

@devhl-labs devhl-labs closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants