Skip to content

[csharp] Add option for nullable reference types #9235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Apr 12, 2021

@mandrean @frankyjuang @shibayan @Blackclaws

The PR adds an option for nullable reference types. Template creators will have to decide to implement it if they choose.

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs
Copy link
Contributor Author

devhl-labs commented Apr 30, 2021

There are other things id like to do but this pr is a prerequisite. My other prs will either be updated or closed.

@devhl-labs
Copy link
Contributor Author

@mandrean @frankyjuang @shibayan @Blackclaws @wing328
Can I get a merge here? Nothing here should affect the current generators as they don't use the option.

@Blackclaws
Copy link
Contributor

LGTM, we should have this option in one way or another @wing328

@Blackclaws
Copy link
Contributor

Actually you could even move the support for parsing the option up to the abstract csharp codegen since that is where the flag is stored.

@devhl-labs
Copy link
Contributor Author

Moved the parsing of the option to the abstract.

@devhl-labs
Copy link
Contributor Author

that second failed check says something about Haskell. Can it be restarted?

@Blackclaws
Copy link
Contributor

@wing328 LGTM, drone build unrelated to changes, circle ci for some reason timed out?

In general I think the nullable reference types can be referenced in the method where it actually uses the nullableTypes list. That way you don't have to add single types to the list but just treat everything as nullable if nullable reference types is set. But that can be an enhancement after merging.

janssen92 added a commit to janssen92/openapi-generator that referenced this pull request Jun 1, 2021
wing328 pushed a commit that referenced this pull request Jun 2, 2021
* Add nullable annotation support to AspNetCoreServer

* Adjust naming for compatability with PR #9235 by @dehl-labs
@wing328
Copy link
Member

wing328 commented Jun 2, 2021

Closed via #9620 instead.

@wing328 wing328 closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants