-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[csharp] Add option for nullable reference types #9235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Add option for nullable reference types #9235
Conversation
There are other things id like to do but this pr is a prerequisite. My other prs will either be updated or closed. |
@mandrean @frankyjuang @shibayan @Blackclaws @wing328 |
LGTM, we should have this option in one way or another @wing328 |
Actually you could even move the support for parsing the option up to the abstract csharp codegen since that is where the flag is stored. |
Moved the parsing of the option to the abstract. |
that second failed check says something about Haskell. Can it be restarted? |
@wing328 LGTM, drone build unrelated to changes, circle ci for some reason timed out? In general I think the nullable reference types can be referenced in the method where it actually uses the nullableTypes list. That way you don't have to add single types to the list but just treat everything as nullable if nullable reference types is set. But that can be an enhancement after merging. |
* Add nullable annotation support to AspNetCoreServer * Adjust naming for compatability with PR #9235 by @dehl-labs
Closed via #9620 instead. |
@mandrean @frankyjuang @shibayan @Blackclaws
The PR adds an option for nullable reference types. Template creators will have to decide to implement it if they choose.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x